From nobody Wed Jun 7 19:29:01 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Qby7y1YBjz4Zm6l; Wed, 7 Jun 2023 19:29:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Qby7y119bz3xGn; Wed, 7 Jun 2023 19:29:02 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1686166142; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=dX0dh0I206s5FcKN+Hjmpyv5BZxRcAzdDtLQky6NY30=; b=TWXIFSmueVZLuKYm/TZsSqazyFNZFzq/H/fKgcRPNryh09Mp+g21yVNXYOW9rbU4u+3qkE MQLBk5ZzESkTNRuTP7l975YDsTXo6Wxb901B3CFWtolt5tlnsxcvAoNNTFtB4ZKUwdILKJ 9gRe29gvReUA8WXyZskN0lTLWfaksXIcz8UnuTzwJmGEQmCRlspBbdcDORCXmcoJvpP/Au YAsnKDEd6/0FJ9gS5GKYBPKq9/Ee3ZJS9KPnSBp9FezvRu8HiCxx/GZTq7nAo+EpnLIqUz G4/oh9JAujJb1T5JlJO1q4rVO13eHas3416V4axz9BDisGPs20g61D8BjzvreQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1686166142; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=dX0dh0I206s5FcKN+Hjmpyv5BZxRcAzdDtLQky6NY30=; b=G0DRlNlDMlzq5j0YBBU3HQ8p1l3amu3o/bwuDlfhLDrQmjUNVWcL7P8FQtOANKNDmFG0DZ kxY2+AponWuez/AlX+bhQ0gQ2oMdeXzBAypCPRjw8cq9JzTSrdXL3VTter+ynB0m8rK7+g /AZrxJI3PKMVMNrCbVoEtIx4y2s9J7tQx/WUsP+hfoYRpim2fzYIt7cFyHMfwYvFg/97zb m/qEQviVX20AX7RVSq3pXUpeH87n698SdlXliPnygas8r25m8qCvVCTtTUdDkbQDo4uiMQ JBZgLsXEBYrajoEj0l+dqgWnEc9eMyV1BldkQhPY71BbonX3gEr0247m47QGrQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1686166142; a=rsa-sha256; cv=none; b=Mb3krnF9zZzSVRY7b1wdhe1z5nHQ4DZe4z38wQS1wxWXRTlCQ33NAaNZZJXz2RX1Ds6BB8 Lw7mpi8TPs5qkw49Xzj3tc3nvw1qvpQCcJFWBY9yjQaD8/JlLIECSynrEPSpmVc8OF/D7F HbuTvriMIvSO9C9ksaQAl1vuxngkU+WhW52rKqufP1JwcKJzvttrXe4AAvGVUYj05UmF0F Pzsf5xi0eLvoT+7A1rc8pMJN/tjdaWSFzqNnORcmSFPwWYrqn+9u7CasM/q6HJLbCsVd0c QWtOVAdSa3SKl+l4wbwtg/dx+/KCI94ZnMRYobvJt2Tsxa7y/0c39jyt27f7vA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Qby7y055HzNl6; Wed, 7 Jun 2023 19:29:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 357JT1LA070239; Wed, 7 Jun 2023 19:29:01 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 357JT1fL070237; Wed, 7 Jun 2023 19:29:01 GMT (envelope-from git) Date: Wed, 7 Jun 2023 19:29:01 GMT Message-Id: <202306071929.357JT1fL070237@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: John Baldwin Subject: git: 653738e895ba - main - ptrace: Clear TDB_BORN during PT_DETACH. List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 653738e895ba022be1179a95a85089e7bc66dbbe Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=653738e895ba022be1179a95a85089e7bc66dbbe commit 653738e895ba022be1179a95a85089e7bc66dbbe Author: John Baldwin AuthorDate: 2023-06-07 19:26:57 +0000 Commit: John Baldwin CommitDate: 2023-06-07 19:28:36 +0000 ptrace: Clear TDB_BORN during PT_DETACH. If a debugger detaches from a process that has a new thread that has not yet executed, the new thread will raise a SIGTRAP signal to report it's thread birth event even after the detach. With the debugger detached, this results in a SIGTRAP sent to the process and typically a core dump. Fix this by clearing TDB_BORN from any new threads during detach. Bump __FreeBSD_version for debuggers to notice when the fix is present. Reported by: GDB's testsuite Reviewed by: kib, markj (previous version) Differential Revision: https://reviews.freebsd.org/D39856 --- sys/kern/kern_fork.c | 2 +- sys/kern/sys_process.c | 2 +- sys/sys/param.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/sys/kern/kern_fork.c b/sys/kern/kern_fork.c index f981747aaf70..944ecf494736 100644 --- a/sys/kern/kern_fork.c +++ b/sys/kern/kern_fork.c @@ -1144,7 +1144,7 @@ fork_return(struct thread *td, struct trapframe *frame) td->td_dbgflags &= ~TDB_STOPATFORK; } PROC_UNLOCK(p); - } else if (p->p_flag & P_TRACED || td->td_dbgflags & TDB_BORN) { + } else if (p->p_flag & P_TRACED) { /* * This is the start of a new thread in a traced * process. Report a system call exit event. diff --git a/sys/kern/sys_process.c b/sys/kern/sys_process.c index 47fdf91b87d5..41434da783c8 100644 --- a/sys/kern/sys_process.c +++ b/sys/kern/sys_process.c @@ -1288,7 +1288,7 @@ kern_ptrace(struct thread *td, int req, pid_t pid, void *addr, int data) SIGSTOP); } td3->td_dbgflags &= ~(TDB_XSIG | TDB_FSTP | - TDB_SUSPEND); + TDB_SUSPEND | TDB_BORN); } if ((p->p_flag2 & P2_PTRACE_FSTP) != 0) { diff --git a/sys/sys/param.h b/sys/sys/param.h index 5bdc3e2ebee4..d3577411e998 100644 --- a/sys/sys/param.h +++ b/sys/sys/param.h @@ -76,7 +76,7 @@ * cannot include sys/param.h and should only be updated here. */ #undef __FreeBSD_version -#define __FreeBSD_version 1400089 +#define __FreeBSD_version 1400090 /* * __FreeBSD_kernel__ indicates that this system uses the kernel of FreeBSD,