Date: Thu, 29 Jan 2015 11:37:10 +0100 From: Dimitry Andric <dim@FreeBSD.org> To: John-Mark Gurney <jmg@funkthat.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r277860 - head/usr.sbin/sa Message-ID: <83A87E21-5D5D-4731-BF49-9310614FB238@FreeBSD.org> In-Reply-To: <20150129082346.GC27103@funkthat.com> References: <201501282222.t0SMMoHU095511@svn.freebsd.org> <20150129082346.GC27103@funkthat.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_D586DE3B-B393-4D5A-BE7B-54D8E718D59A Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii On 29 Jan 2015, at 09:23, John-Mark Gurney <jmg@funkthat.com> wrote: > > Dimitry Andric wrote this message on Wed, Jan 28, 2015 at 22:22 +0000: >> Replace the VERSION_KEY define with a writable char array, so no const >> qualifier needs to be dropped anymore. > > You do realize that you should juse use __DECONST for this instead? > > This moves the data from .rodata into .data making it writable, and > also means that bad programs could end up stop working, instead of > faulting when someone tries to change the version string... I don't see the risk here, the db api does not actually modify the incoming key (the API is just badly designed). But if you think it is nicer to use __DECONST, feel free to change it. -Dimitry --Apple-Mail=_D586DE3B-B393-4D5A-BE7B-54D8E718D59A Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.26 iEYEARECAAYFAlTKDVoACgkQsF6jCi4glqMcoACfXHpsvTNYnQvm9oQApkywkEHC W5sAoKdeQ6NiskFl7vBa51ooRplMo088 =j+6C -----END PGP SIGNATURE----- --Apple-Mail=_D586DE3B-B393-4D5A-BE7B-54D8E718D59A--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?83A87E21-5D5D-4731-BF49-9310614FB238>