From owner-freebsd-ports@FreeBSD.ORG  Fri Feb 17 03:38:20 2012
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B08D0106566B
	for <freebsd-ports@freebsd.org>; Fri, 17 Feb 2012 03:38:20 +0000 (UTC)
	(envelope-from lists@eitanadler.com)
Received: from mail-ww0-f42.google.com (mail-ww0-f42.google.com [74.125.82.42])
	by mx1.freebsd.org (Postfix) with ESMTP id 3FCC38FC0C
	for <freebsd-ports@freebsd.org>; Fri, 17 Feb 2012 03:38:19 +0000 (UTC)
Received: by wgbgn7 with SMTP id gn7so986070wgb.1
	for <freebsd-ports@freebsd.org>; Thu, 16 Feb 2012 19:38:19 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=eitanadler.com; s=0xdeadbeef;
	h=mime-version:in-reply-to:references:from:date:message-id:subject:to
	:cc:content-type;
	bh=geOpBUMRFLHv4INS39WvU/K23S5ltsWYaRP+/0JOxUA=;
	b=kQVS4F4ttp1hzjxNHfN0KRF7mtCr+YRFJI8cN+ZAMhOGeRMjHHuMo/3u7/GBiHWm3A
	fNZsNbg+fWdpp0YJfYpI6kQQYC/Imhoxni8PBLUohh2gV5Ge2jqg4sDXeKAlhcL52s46
	7KUC0HqB58sIw5MjKOkKR0CZjFyLU+pxeWR70=
Received: by 10.216.138.234 with SMTP id a84mr2810354wej.40.1329449899187;
	Thu, 16 Feb 2012 19:38:19 -0800 (PST)
MIME-Version: 1.0
Received: by 10.223.15.90 with HTTP; Thu, 16 Feb 2012 19:37:49 -0800 (PST)
In-Reply-To: <2784.46.129.107.107.1329442146.squirrel@mymail.acsalaska.net>
References: <2621.46.129.107.107.1329424451.squirrel@mymail.acsalaska.net>
	<CAF6rxgm37WntT51QV6YccrZ6Yv7kOp9mL83=eDN6NdpR_pk0Sg@mail.gmail.com>
	<2784.46.129.107.107.1329442146.squirrel@mymail.acsalaska.net>
From: Eitan Adler <lists@eitanadler.com>
Date: Thu, 16 Feb 2012 22:37:49 -0500
Message-ID: <CAF6rxgnPHVK6AbfLBwwyC12WYYLL33mmWzjU4ddJ1O4wMDJcew@mail.gmail.com>
To: rflynn@acsalaska.net
Content-Type: text/plain; charset=UTF-8
X-Gm-Message-State: ALoCoQmh1mGPzOk1vFkD22FvhaAJaU5ncOAoOVDSA2teWcZyvxDnlPDMtgNIfIFbAIsbaTREXHIP
Cc: freebsd-ports@freebsd.org
Subject: Re: CFR: net-mgmt/observium
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 17 Feb 2012 03:38:20 -0000

On Thu, Feb 16, 2012 at 8:29 PM,  <rflynn@acsalaska.net> wrote:
> Hi Eitan,
>
>> why is fping in the files/ directory instead of being fetched from somewhere?
>
> Cause I was looking for EXTRA_FILES and similar knobs and gave up, while I
> should be looking at EXTRACT_ONLY. Got it fixed locally.

Understood.

>> patch-html::graph-realtime.php should be upstreamed instead being
>> locally modified for FreeBSD.
>
> Hmm. If the FreeBSD php is vanilla, things "work". As soon as you put a
> sane (f.e. php.ini-production) php.ini in play, things stop working, the
> culprit being short_open_tags. My intention was to not flood maintainer mail
> relating to that.

I see the problem. I wish upstream would release a fix but I do not
oppose a REINPLACE option as you mention below.
When you file the PR please explicitly mention why you are patching
the source (and the committer should likely include that information
in the commit log).
We need to work towards reducing the number of patches in ports tree.

> I probably can rewrite it as an REINPLACE_CMD to save the ports tree 8k in
> $FILESDIR.




-- 
Eitan Adler