From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Apr 27 23:30:02 2010 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6812E1065670 for ; Tue, 27 Apr 2010 23:30:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 2D8988FC1A for ; Tue, 27 Apr 2010 23:30:02 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o3RNU1OK061685 for ; Tue, 27 Apr 2010 23:30:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o3RNU1Dq061682; Tue, 27 Apr 2010 23:30:01 GMT (envelope-from gnats) Resent-Date: Tue, 27 Apr 2010 23:30:01 GMT Resent-Message-Id: <201004272330.o3RNU1Dq061682@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Ondra Knezour Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7F586106566C for ; Tue, 27 Apr 2010 23:23:41 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 702EE8FC08 for ; Tue, 27 Apr 2010 23:23:41 +0000 (UTC) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o3RNNeae066629 for ; Tue, 27 Apr 2010 23:23:40 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id o3RNNe7N066621; Tue, 27 Apr 2010 23:23:40 GMT (envelope-from nobody) Message-Id: <201004272323.o3RNNe7N066621@www.freebsd.org> Date: Tue, 27 Apr 2010 23:23:40 GMT From: Ondra Knezour To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/146100: sysutils/smartmontools: Add support for periodic ciss devices health monitoring X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Apr 2010 23:30:02 -0000 >Number: 146100 >Category: ports >Synopsis: sysutils/smartmontools: Add support for periodic ciss devices health monitoring >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Tue Apr 27 23:30:01 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Ondra Knezour >Release: 7.2-STABLE >Organization: >Environment: FreeBSD sb.weboutsourcing.cz 7.2-STABLE FreeBSD 7.2-STABLE #0: Mon Jun 8 22:16:18 CEST 2009 root@sb.weboutsourcing.cz:/usr/obj/usr/src/sys/GENERIC i386 >Description: Current version of /usr/local/etc/periodic/smart can check SMART health status only for ad/da/twa/twe devices. Attached patch extends its support for ciss devices. Additionally, review please my change of handling of cd* devices. >How-To-Repeat: >Fix: Attached unified diff works fine for me. Patch attached with submission follows: --- /usr/ports/sysutils/smartmontools/files/smart.in 2010-03-10 14:12:53.000000000 +0100 +++ /usr/local/etc/periodic/daily/smart.in 2010-04-28 01:04:43.000000000 +0200 @@ -40,14 +40,16 @@ device="${device#/dev/}" devflags="" case ${device} in - cd*) continue + cd*) ;; + tw[ae]*) devflags="-d3ware,${device##tw[ae][0-9]*,}" + device="/dev/${device%,[0-9]*}" ;; - tw[ae]*) devflags="-d3ware,${device#tw[ae][0-9]*,}" - device="/dev/${device%,[0-9]*}" + ciss*) devflags="-dcciss,${device##ciss[0-9]*,}" + device="/dev/${device%,[0-9]*}" ;; /*) ;; *) device="/dev/${device}" - ;; + ;; esac if [ -e ${device} ]; then >Release-Note: >Audit-Trail: >Unformatted: