Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 30 Dec 2013 15:50:58 +0400
From:      Boris Samorodov <bsam@passap.ru>
To:        Mathieu Arnold <mat@FreeBSD.org>, Boris Samorodov <bsam@FreeBSD.org>,  ports-committers@freebsd.org, svn-ports-all@freebsd.org,  svn-ports-head@freebsd.org
Subject:   Re: svn commit: r338091 - head/x11-servers/xorg-server
Message-ID:  <52C15E22.50700@passap.ru>
In-Reply-To: <D855B25545B83425A3CAEE9C@ogg.in.absolight.net>
References:  <201312301141.rBUBfI9R099001@svn.freebsd.org> <D855B25545B83425A3CAEE9C@ogg.in.absolight.net>

next in thread | previous in thread | raw e-mail | index | archive | help
30.12.2013 15:45, Mathieu Arnold пишет:
> +--On 30 décembre 2013 11:41:18 +0000 Boris Samorodov <bsam@FreeBSD.org>
> wrote:
> | Author: bsam
> | Date: Mon Dec 30 11:41:18 2013
> | New Revision: 338091
> | URL: http://svnweb.freebsd.org/changeset/ports/338091
> | 
> | Log:
> |   Fix PLIST_SUB (add a space after @comment) for non-default option.
> |   
> |   Reported and tested by:	Andrea Venturoli <ml@netfence.it>
> |   Approved by:		x11 (kwm)
> | 
> | Modified:
> |   head/x11-servers/xorg-server/Makefile
> | 
> | Modified: head/x11-servers/xorg-server/Makefile
> | =========================================================================
> | ===== --- head/x11-servers/xorg-server/Makefile	Mon Dec 30 11:40:41 2013
> | 	(r338090) +++ head/x11-servers/xorg-server/Makefile	Mon Dec 30 11:41:18
> | 2013	(r338091) @@ -111,7 +111,7 @@
> | CONFIGURE_ARGS+=--enable-install-setuid=
> |  PLIST_SUB+=	SUID=""
> |  .else
> |  CONFIGURE_ARGS+=--enable-install-setuid=no
> | -PLIST_SUB+=	SUID="@comment"
> | +PLIST_SUB+=	SUID="@comment "
> |  .endif
> 
> You could do without the PLIST_SUB+= (and the bugs that comes with them)
> with OPTIONS_SUB=yes which will give you a PLIST_SUB for each OPTIONS.

Thanks for pointing this out.

Well, my intention was just to do a tiny patch that fix a build. Other
changes were not intended.

-- 
WBR, Boris Samorodov (bsam)
FreeBSD Committer, http://www.FreeBSD.org The Power To Serve



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?52C15E22.50700>