Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 06 Oct 2012 23:39:08 +0200
From:      Dimitry Andric <dim@FreeBSD.org>
To:        Marcel Moolenaar <marcel@FreeBSD.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r241298 - in head: . gnu/usr.bin/cc/cc_int gnu/usr.bin/cc/include kerberos5 kerberos5/tools/asn1_compile kerberos5/tools/slc lib/clang/include share/mk tools/build/make_check usr.sbin/c...
Message-ID:  <5070A4FC.4080802@FreeBSD.org>
In-Reply-To: <201210062001.q96K16Or030755@svn.freebsd.org>
References:  <201210062001.q96K16Or030755@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 2012-10-06 22:01, Marcel Moolenaar wrote:
>    2.  Remove the use of -E. It's not needed in our build because we use ?= for
>        the respective variables, which means that we'll take the environment
>        value (if any) anyway.

No, this will break builds of 32-bit libraries on amd64, at least when
CC/CXX etc are set in make.conf.  I put this in specifically in r227120.

Please revert this particular change, unless you have tested that it
works correctly, with e.g.  CC=clang in make.conf.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5070A4FC.4080802>