From owner-svn-src-head@FreeBSD.ORG Sun Sep 14 12:42:56 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 21B35972; Sun, 14 Sep 2014 12:42:56 +0000 (UTC) Received: from esa-annu.net.uoguelph.ca (esa-annu.mail.uoguelph.ca [131.104.91.36]) by mx1.freebsd.org (Postfix) with ESMTP id CBA2A204; Sun, 14 Sep 2014 12:42:55 +0000 (UTC) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AqAEAKyMFVSDaFve/2dsb2JhbABghDuCeM4agRt4hC1WGxoCDRIHAl+IUaJMlQsBF4EsjUojNIJ/gVMFskeCG4FfIYE2QYECAQEB X-IronPort-AV: E=Sophos;i="5.04,521,1406606400"; d="scan'208";a="155072597" Received: from muskoka.cs.uoguelph.ca (HELO zcs3.mail.uoguelph.ca) ([131.104.91.222]) by esa-annu.net.uoguelph.ca with ESMTP; 14 Sep 2014 08:42:54 -0400 Received: from zcs3.mail.uoguelph.ca (localhost.localdomain [127.0.0.1]) by zcs3.mail.uoguelph.ca (Postfix) with ESMTP id 22F54B3F14; Sun, 14 Sep 2014 08:42:54 -0400 (EDT) Date: Sun, 14 Sep 2014 08:42:54 -0400 (EDT) From: Rick Macklem To: Hans Petter Selasky Message-ID: <25891118.35942355.1410698574131.JavaMail.root@uoguelph.ca> Subject: Re: svn commit: r271504 - in head/sys: dev/oce dev/vmware/vmxnet3 dev/xen/netfront net netinet ofed/drivers/net/mlx4 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [172.17.91.202] X-Mailer: Zimbra 7.2.6_GA_2926 (ZimbraWebClient - FF3.0 (Win)/7.2.6_GA_2926) Cc: svn-src-head@freebsd.org, Adrian Chadd X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Sep 2014 12:42:56 -0000 Hans Petter Selasky wrote: [stuff snipped for brevity] > > Btw, your patch calls sbsndptr() in tcp_output(), which advances > > sb_sndptroff and sb_sndptr by the length. > > Then it loops around and reduces the length for the case where > > there are too many mbufs in the chain. > > > > Right, though this patch would need to understand segment lengths too > and not only count them. Yep. I didn't mean that you would want to use the patch, I was just suggesting that you might want to consider doing something like sbsnfmbuf() so that sb_sndptroff and sb_sndptr aren't being advanced in your patch. All I did to make sbsndmbuf() was clone sbsndptr(), then take out the code that updated sb_sndptroff and sb_sndptr plus add a little bit that I found useful for my patch. As an aside, although allowing specification of a limit for segment size sounds like a good plan, I am not aware of hardware that can't handle a large segment? Good luck with it, rick