From nobody Fri Jul 4 06:20:36 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bYNmh2zfzz60t7V; Fri, 04 Jul 2025 06:20:52 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4bYNmg1MVjz3SpN; Fri, 04 Jul 2025 06:20:51 +0000 (UTC) (envelope-from kostikbel@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: from tom.home (kib@localhost [127.0.0.1] (may be forged)) by kib.kiev.ua (8.18.1/8.18.1) with ESMTP id 5646Kb9Y042754; Fri, 4 Jul 2025 09:20:40 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 5646Kb9Y042754 Received: (from kostik@localhost) by tom.home (8.18.1/8.18.1/Submit) id 5646KaoH042753; Fri, 4 Jul 2025 09:20:36 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 4 Jul 2025 09:20:36 +0300 From: Konstantin Belousov To: Ruslan Bukin Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 906d7a4b521c - main - hwt: fix !SMP build. Message-ID: References: <202507032049.563KnGxr033283@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202507032049.563KnGxr033283@gitrepo.freebsd.org> X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on tom.home X-Rspamd-Queue-Id: 4bYNmg1MVjz3SpN X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US] On Thu, Jul 03, 2025 at 08:49:16PM +0000, Ruslan Bukin wrote: > The branch main has been updated by br: > > URL: https://cgit.FreeBSD.org/src/commit/?id=906d7a4b521c19b2b1ae3ec844b5d4626f2fd529 > > commit 906d7a4b521c19b2b1ae3ec844b5d4626f2fd529 > Author: Ruslan Bukin > AuthorDate: 2025-07-03 20:43:01 +0000 > Commit: Ruslan Bukin > CommitDate: 2025-07-03 20:43:01 +0000 > > hwt: fix !SMP build. > > Sponsored by: UKRI > --- > sys/dev/hwt/hwt_ioctl.c | 2 ++ > sys/dev/hwt/hwt_vm.c | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/sys/dev/hwt/hwt_ioctl.c b/sys/dev/hwt/hwt_ioctl.c > index 04133838d292..592db4931bb4 100644 > --- a/sys/dev/hwt/hwt_ioctl.c > +++ b/sys/dev/hwt/hwt_ioctl.c > @@ -305,9 +305,11 @@ hwt_ioctl_alloc_mode_cpu(struct thread *td, struct hwt_owner *ho, > return (error); > > CPU_FOREACH_ISSET(cpu_id, &cpu_map) { > +#ifdef SMP > /* Ensure CPU is not halted. */ > if (CPU_ISSET(cpu_id, &hlt_cpus_mask)) > return (ENXIO); > +#endif > #if 0 > /* TODO: Check if the owner have this cpu configured already. */ > ctx = hwt_owner_lookup_ctx_by_cpu(ho, halloc->cpu); > diff --git a/sys/dev/hwt/hwt_vm.c b/sys/dev/hwt/hwt_vm.c > index a6799c30300d..6c55e218dcec 100644 > --- a/sys/dev/hwt/hwt_vm.c > +++ b/sys/dev/hwt/hwt_vm.c > @@ -213,9 +213,11 @@ hwt_vm_start_cpu_mode(struct hwt_context *ctx) > CPU_ZERO(&enable_cpus); > > CPU_FOREACH_ISSET(cpu_id, &ctx->cpu_map) { > +#ifdef SMP > /* Ensure CPU is not halted. */ > if (CPU_ISSET(cpu_id, &hlt_cpus_mask)) > continue; > +#endif > > hwt_backend_configure(ctx, cpu_id, cpu_id); > This again raises a wonder: should we drop SMP option at all?