Date: Sun, 1 Apr 2001 00:00:03 -0800 (PST) From: Peter Philipp <pjp@dega.daemonium.com> To: freebsd-bugs@FreeBSD.org Subject: [bde@zeta.org.au: Re: kern/25445: /usr/src/usr.bin/vmstat/vmstat.c & /usr/src/sys/sys/malloc.h type differences Message-ID: <200104010800.f31803b33326@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/25445; it has been noted by GNATS.
From: Peter Philipp <pjp@dega.daemonium.com>
To: freebsd-gnats-submit@FreeBSD.ORG
Cc:
Subject: [bde@zeta.org.au: Re: kern/25445: /usr/src/usr.bin/vmstat/vmstat.c & /usr/src/sys/sys/malloc.h type differences
Date: Sun, 1 Apr 2001 02:59:57 -0500
Ok well since this is still an open pr here is the patch to make usr.bin/vmstat
compile cleanly against -Wformat (yes -Wformat should still be turned on
globally as Bruce Evans suggests) but would most likely need more fixing than
this particular PR calls for. If someone who has an alpha can add temporarily
-Wformat into the usr.bin/vmstat/Makefile near the CFLAGS+= line and make if
there is no errrors with the formatting then dandy commit/close PR.
--- malloc.h.orig Tue Feb 27 22:49:28 2001
+++ malloc.h Sun Apr 1 03:47:41 2001
@@ -56,7 +56,7 @@
long ks_limit; /* most that are allowed to exist */
long ks_size; /* sizes of this thing that are allocated */
long ks_inuse; /* # of packets of this type currently in use */
- int64_t ks_calls; /* total packets of this type ever allocated */
+ long ks_calls; /* total packets of this type ever allocated */
long ks_maxused; /* maximum number ever used */
u_long ks_magic; /* if it's not magic, don't touch it */
const char *ks_shortdesc; /* short description */
@@ -102,7 +102,7 @@
struct kmembuckets {
caddr_t kb_next; /* list of free blocks */
caddr_t kb_last; /* last free block */
- int64_t kb_calls; /* total calls to allocate this size */
+ long kb_calls; /* total calls to allocate this size */
long kb_total; /* total number of blocks allocated */
long kb_elmpercl; /* # of elements in this sized allocation */
long kb_totalfree; /* # of free elements in this bucket */
--
- -
Peter Philipp <pjp@daemonium.com>
Daemonium
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200104010800.f31803b33326>