From nobody Wed Jul 16 08:51:58 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bhqYV3xtwz62HCF; Wed, 16 Jul 2025 08:51:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bhqYV2nJpz3Gfj; Wed, 16 Jul 2025 08:51:58 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1752655918; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AAq2QP+FK6nT/x6P3CqCC+qvfK6xM9Y09ciNjhOdUyM=; b=CnRlfU+GPcI9+IBrTnjpFQUH9JH8lU9+0eQdgSGWgKEc6C+Kib+FHLySXpgJFDMNaZTblF zeSUL/HAe8rEnA/sA938ms6+lur9YmMGrEw5iLNjF8B72YZR+5ofoWUj5Yzjjv2ibCJR+n y0AhhdxscCPZ/Y9iqm0nksgu1SlPab40Q3GSF61znA6dTkZ00djWYEGkm8g/rw+1iQ7H1b zbG1xJDsZznikPPejyLPs0dL7u0D8ZJMjWtOcewovXnpMUlAXpJA6hUJApIXb6TmNIkXpM D5BZ94TgBXP35qsxVXRPptEoeOvNsckJ5L1836NHULMipsBTRfN0rS3XM6FgZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1752655918; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AAq2QP+FK6nT/x6P3CqCC+qvfK6xM9Y09ciNjhOdUyM=; b=bape32rdEXVRJLboAsiIw3NDf6/YHE5qBrWDusRZDPb33K/9Cw0z8Dr2WCrbQGMdzwiVNv FelToaOjsentMrmobMwqhMRxb6VB/6ZGOUZC9qqUcSWIdzj81qVWEadS1E95ZztRTX9kFE t/V3Zf3b9X7ZbmpjcEfL11bHksmQsTD7Gfnz6Qxw4ofE86+uyhPzRd9W9/U/oY3uIA1+iP pmZlNckylovA8GKJhywUPCJ/Lu1CXWWJRK4Ao5z6u2MP0/eMK6+mv32B62FzgSprohXQkx SQmC3eniMmKQQOcjzZlPs38OubjuaYF4TXdjzh/FeO/5I5p2RKbdwsjBn+G0Dg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1752655918; a=rsa-sha256; cv=none; b=LErmKsRoKF0L2fr4oFIR0oNr63hAyHBOUei6Z+crZ5QhH2f7unae/GsT358UQVTO/WNU7o LMV9tk5iDrfrnnAc0bIkHfNI4VzJ5cZrvJ2fK4MDYvSKVRJO7uHrpdsVSxDYu5zQKxAuO2 lMPDwrjYj3EgF2IpjEjUUtBEMeWJ9sRW/2J2sJ4Ti6/ngmslnKZFQVXIeZ6GbqEiJba3AV bU+kuVCQWdpP2L1RtJa7XCb57vYRgbFIVTeujHrcdMigdK1E3EI2WAH9P2N5OuJAab+PgD Obc3hM8GVP5Ib1qr8qPjcKuUWHUy+3Vs3AuW4vmUMqjCF5tS1YErvkgsNPVwGg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bhqYV2JC9z1HHv; Wed, 16 Jul 2025 08:51:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 56G8pwoX003063; Wed, 16 Jul 2025 08:51:58 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 56G8pwkl003060; Wed, 16 Jul 2025 08:51:58 GMT (envelope-from git) Date: Wed, 16 Jul 2025 08:51:58 GMT Message-Id: <202507160851.56G8pwkl003060@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mateusz Guzik Subject: git: 31d1c080ab7b - main - vfs cache: drop SDT_PROBES_ENABLED usage List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mjg X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 31d1c080ab7b6d713f7b5fd8ff78e07d63645bc6 Auto-Submitted: auto-generated The branch main has been updated by mjg: URL: https://cgit.FreeBSD.org/src/commit/?id=31d1c080ab7b6d713f7b5fd8ff78e07d63645bc6 commit 31d1c080ab7b6d713f7b5fd8ff78e07d63645bc6 Author: Mateusz Guzik AuthorDate: 2025-07-16 08:38:22 +0000 Commit: Mateusz Guzik CommitDate: 2025-07-16 08:50:35 +0000 vfs cache: drop SDT_PROBES_ENABLED usage since sdt probes started being hot patched This eliminates a now spurious branch on fpl.status --- sys/kern/vfs_cache.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/sys/kern/vfs_cache.c b/sys/kern/vfs_cache.c index ec3f947ffa55..89c1d779f04c 100644 --- a/sys/kern/vfs_cache.c +++ b/sys/kern/vfs_cache.c @@ -6421,15 +6421,11 @@ out: cache_fpl_smr_assert_not_entered(&fpl); cache_fpl_assert_status(&fpl); *status = fpl.status; - if (SDT_PROBES_ENABLED()) { - SDT_PROBE3(vfs, fplookup, lookup, done, ndp, fpl.line, fpl.status); - if (fpl.status == CACHE_FPL_STATUS_HANDLED) - SDT_PROBE4(vfs, namei, lookup, return, error, ndp->ni_vp, true, - ndp); - } - + SDT_PROBE3(vfs, fplookup, lookup, done, ndp, fpl.line, fpl.status); if (__predict_true(fpl.status == CACHE_FPL_STATUS_HANDLED)) { MPASS(error != CACHE_FPL_FAILED); + SDT_PROBE4(vfs, namei, lookup, return, error, ndp->ni_vp, true, + ndp); if (error != 0) { cache_fpl_cleanup_cnp(fpl.cnp); MPASS(fpl.dvp == NULL);