Date: Wed, 06 Oct 2004 09:41:41 -0600 (MDT) From: "M. Warner Losh" <imp@bsdimp.com> To: vova@fbsd.ru Cc: mobile@freebsd.org Subject: Re: Please test fix for bad Vcc errors Message-ID: <20041006.094141.87687724.imp@bsdimp.com> In-Reply-To: <1097067591.2282.2.camel@localhost> References: <20041006.004353.08394386.imp@bsdimp.com> <1097067591.2282.2.camel@localhost>
next in thread | previous in thread | raw e-mail | index | archive | help
----Next_Part(Wed_Oct__6_09:41:41_2004_076)--
Content-Type: Text/Plain; charset=koi8-r
Content-Transfer-Encoding: quoted-printable
In message: <1097067591.2282.2.camel@localhost>
Vladimir Grebenschikov <vova@fbsd.ru> writes:
: =F7 =D3=D2, 06/10/2004 =D7 00:43 -0600, M. Warner Losh =D0=C9=DB=C5=D4=
:
: =
: Hi
: =
: > If you have an older laptop that's getting bad Vcc errors, please t=
est
: > this patch. There's a number of laptops with resource issues. If =
you
: > are using ACPI, this won't change anything (I have a separate patch=
: > for that).
: =
: How about separate patch for ACPI-based laptops ?
OK. Here's what I think will fix acpi based ones. I've already
committed it to current, but will be interested in what people find.
Warner
----Next_Part(Wed_Oct__6_09:41:41_2004_076)--
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: inline; filename="acpi.diff"
Index: acpi_pcib_acpi.c
===================================================================
RCS file: /home/ncvs/src/sys/dev/acpica/acpi_pcib_acpi.c,v
retrieving revision 1.40
retrieving revision 1.41
diff -u -r1.40 -r1.41
--- acpi_pcib_acpi.c 22 Sep 2004 15:46:16 -0000 1.40
+++ acpi_pcib_acpi.c 6 Oct 2004 07:26:52 -0000 1.41
@@ -305,16 +305,16 @@
u_long start, u_long end, u_long count, u_int flags)
{
/*
- * If no memory preference is given, use upper 2GB slot most
+ * If no memory preference is given, use upper 32MB slot most
* bioses use for their memory window. Typically other bridges
* before us get in the way to assert their preferences on memory.
* Hardcoding like this sucks, so a more MD/MI way needs to be
* found to do it. This is typically only used on older laptops
- * that don't have pci busses behind pci bridge, so assuming < 2GB
+ * that don't have pci busses behind pci bridge, so assuming > 32MB
* is liekly OK.
*/
if (type == SYS_RES_MEMORY && start == 0UL && end == ~0UL)
- start = 0x80000000;
+ start = 0xfe000000;
return (bus_generic_alloc_resource(dev, child, type, rid, start, end,
count, flags));
}
----Next_Part(Wed_Oct__6_09:41:41_2004_076)----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041006.094141.87687724.imp>