From owner-freebsd-bugs@freebsd.org Fri Jul 28 10:11:35 2017 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6DF37DC2516 for ; Fri, 28 Jul 2017 10:11:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 5C5C37F6E9 for ; Fri, 28 Jul 2017 10:11:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v6SABZ8M048336 for ; Fri, 28 Jul 2017 10:11:35 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 221067] vfs.root.mountfrom.options="ro" did not take effect for a zfs root filesystem Date: Fri, 28 Jul 2017 10:11:35 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: wheelcomplex@gmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Jul 2017 10:11:35 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D221067 Bug ID: 221067 Summary: vfs.root.mountfrom.options=3D"ro" did not take effect for a zfs root filesystem Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: kern Assignee: freebsd-bugs@FreeBSD.org Reporter: wheelcomplex@gmail.com Created attachment 184793 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D184793&action= =3Dedit prototype fix for reference when using a readonly filesystem as root filesystem, vfs.root.mountfrom.options=3D"ro" should be the only way to tell kernel mou= nt the filesystem in readonly. This works for UFS but ZFS.=20 Currently, during kernel mountroot, zfs_domount always try to open underlay= er device for write when try to import the pool and failed. When kernel try to import pool by calling spa_import_rootpool(pname) in sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vfsops.c, there is not parameter to tell spa_load to open underlayer device on readonly. This is t= he source of this issue. The attachment is a prototype fix for reference. It query vfs.root.mountfrom.options when open underlayer device to set readonly flag. A new parameter for spa_import_rootpool meight be a better solution. --=20 You are receiving this mail because: You are the assignee for the bug.=