Date: Mon, 1 Feb 2010 18:34:50 GMT From: Darren Pilgrim <darren.pilgrim@gmail.com> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/143447: [patch] fix ports/mail/squirrelmail/bsd.squirrelmail.mk to not override USE_PHP set in plugin Makefiles Message-ID: <201002011834.o11IYoQr099180@www.freebsd.org> Resent-Message-ID: <201002011840.o11Ie1uc073045@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 143447
>Category: ports
>Synopsis: [patch] fix ports/mail/squirrelmail/bsd.squirrelmail.mk to not override USE_PHP set in plugin Makefiles
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Mon Feb 01 18:40:01 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator: Darren Pilgrim
>Release: 7.2
>Organization:
>Environment:
FreeBSD [redacted] 7.2-RELEASE-p1-jc2 FreeBSD 7.2-RELEASE-p1-jc2 #0: Thu Jun 18 15:16:49 PDT 2009 user@jail8.johncompanies.com:/usr/obj/usr/src/sys/jail8 amd64
>Description:
The bsd.squirrelmail.mk is a Makefile include used by squirrelmail-plugin ports which provides common routines for correctly installing and activating plugins. The include file sets USE_PHP=yes unconditionally. If a plugin requires PHP extensions, this setting overrides any USE_PHP setting (e.g., USE_PHP=xmlrpc) in the plugin Makefile.
>How-To-Repeat:
1. Create a Makefile that sets USE_PHP to something other than yes;
2. Run make -V USE_PHP and observe your setting;
3. Modify the Makefile to include ${PORTSDIR}/mail/squirrelmail/bsd.squirrelmail.mk after your USE_PHP setting;
4. Run make -V USE_PHP again and observe USE_PHP is now set to "yes" instead of your setting;
>Fix:
Modify bsd.squirrelmail.mk to set USE_PHP only if unset (i.e., ?= operator). The attached patch does exactly this.
Patch attached with submission follows:
--- bsd.squirrelmail.mk.orig 2010-01-14 19:16:29.000000000 -0800
+++ bsd.squirrelmail.mk 2010-01-31 15:18:00.000000000 -0800
@@ -27,7 +27,7 @@
NO_BUILD= yes
NO_WRKSUBDIR= yes
-USE_PHP= yes
+USE_PHP?= yes
WANT_PHP_WEB= yes
SQUIRREL_PLUGIN_NAME?= ${PORTNAME}
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201002011834.o11IYoQr099180>