From owner-freebsd-bugs@freebsd.org Fri Apr 5 02:43:02 2019 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BBA3C156617B for ; Fri, 5 Apr 2019 02:43:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 524327166A for ; Fri, 5 Apr 2019 02:43:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 11236156617A; Fri, 5 Apr 2019 02:43:02 +0000 (UTC) Delivered-To: bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E131F1566179 for ; Fri, 5 Apr 2019 02:43:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7BF4071667 for ; Fri, 5 Apr 2019 02:43:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id CAF345135 for ; Fri, 5 Apr 2019 02:43:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x352h0LU046675 for ; Fri, 5 Apr 2019 02:43:00 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x352h0Up046674 for bugs@FreeBSD.org; Fri, 5 Apr 2019 02:43:00 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 237030] ls -R produces invalid output when recursing dot directories Date: Fri, 05 Apr 2019 02:43:00 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 11.2-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: parakleta@darkreality.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Apr 2019 02:43:03 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D237030 Bug ID: 237030 Summary: ls -R produces invalid output when recursing dot directories Product: Base System Version: 11.2-STABLE Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: bin Assignee: bugs@FreeBSD.org Reporter: parakleta@darkreality.org Created attachment 203394 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D203394&action= =3Dedit Patch to skip recursion of dot directories `ls -R` doesn't print dot directories (i.e. those with a '.' prefix) nor th= eir contents but it still recurses through them and will print the contents of directories within. The standard could be argued as ambiguous on this point (see bug #206192), = but generally the agreement is that this is the wrong behaviour. Note addition= ally that FreeBSD doesn't exhibit either of the described behaviours because it doesn't print the contents of a dot directory, only the contents of non-dot-directories contained in dot-directories. As an example set up a directory as follows: `mkdir test; cd test; git init` Then `ls -R` outputs the following: <--> applypatch-msg.sample* pre-applypatch.sample* pre-rebase.sample= *=20=20=20 update.sample* commit-msg.sample* pre-commit.sample* pre-receive.sampl= e* post-update.sample* pre-push.sample*=20=20=20=20=20=20=20=20=20= =20 prepare-commit-msg.sample* ./.git/info: exclude ./.git/objects: info/ pack/ ./.git/objects/info: ./.git/objects/pack: ./.git/refs: heads/ tags/ ./.git/refs/heads: ./.git/refs/tags: <--> Now run `touch file; ls -R` and the result changes as follows: <--> file ./.git/branches: ./.git/hooks: applypatch-msg.sample* pre-applypatch.sample* pre-rebase.sample= *=20=20=20 update.sample* commit-msg.sample* pre-commit.sample* pre-receive.sampl= e* post-update.sample* pre-push.sample*=20=20=20=20=20=20=20=20=20= =20 prepare-commit-msg.sample* ./.git/info: exclude ./.git/objects: info/ pack/ ./.git/objects/info: ./.git/objects/pack: ./.git/refs: heads/ tags/ ./.git/refs/heads: ./.git/refs/tags: <--> Notice the extra directories that are now output that weren't before. The solution is quite simple, to just skip the recursion in the event that = the directory's children are skipped, and attached is a patch which does just t= hat. --=20 You are receiving this mail because: You are the assignee for the bug.=