From owner-svn-src-all@FreeBSD.ORG Thu Oct 1 13:13:08 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id ACA28106568B for ; Thu, 1 Oct 2009 13:13:08 +0000 (UTC) (envelope-from cokane@FreeBSD.org) Received: from mail-out1.fuse.net (mail-out1.fuse.net [216.68.8.175]) by mx1.freebsd.org (Postfix) with ESMTP id 6EF988FC16 for ; Thu, 1 Oct 2009 13:13:08 +0000 (UTC) X-CNFS-Analysis: v=1.1 cv=Jf3tspjE8XI4z6saXnuFbjgHz4WKruKDsdWNlYDB8z0= c=1 sm=0 a=YYkPiygOjqcA:10 a=6I5d2MoRAAAA:8 a=AAr3Z61ZW07-4kdbiQEA:9 a=OFa2qiRyNEw8OjCMMmVQ2D5uWT4A:4 a=SV7veod9ZcQA:10 a=O5IIhqKZ-maHpabVsXAA:9 a=j0dHktmAlzG96SuhTk7X2PjxDUQA:4 a=LkYvsgB9u1MH7Ao0BLhsLg==:117 X-CM-Score: 0 X-Scanned-by: Cloudmark Authority Engine Authentication-Results: ecout1 smtp.mail=cokane@FreeBSD.org; spf=softfail Received-SPF: softfail (ecout1: transitional domain FreeBSD.org does not designate 74.215.227.9 as permitted sender) Received: from [74.215.227.9] ([74.215.227.9:50208] helo=mail.colemankane.org) by ecout1 (envelope-from ) (ecelerity 2.2.2.43 r()) with ESMTP id 9A/56-02412-047A4CA4; Thu, 01 Oct 2009 08:57:37 -0400 Received: from [172.20.0.76] (rrcs-96-11-231-210.central.biz.rr.com [96.11.231.210]) by mail.colemankane.org (Postfix) with ESMTPSA id 4D1EE1143E; Thu, 1 Oct 2009 10:02:33 -0400 (EDT) From: Coleman Kane To: Dag-Erling =?ISO-8859-1?Q?Sm=F8rgrav?= , "Bjoern A. Zeeb" In-Reply-To: <86eipno12p.fsf@ds4.des.no> References: <200910010243.n912hpSM034846@svn.freebsd.org> <86eipno12p.fsf@ds4.des.no> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-Y/dW7pGoxMRHIIDsRAQh" Organization: FreeBSD Project Date: Thu, 01 Oct 2009 08:56:57 -0400 Message-Id: <1254401817.4255.14.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.26.3 FreeBSD GNOME Team Port Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r197654 - head/sys/dev/if_ndis X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Oct 2009 13:13:08 -0000 --=-Y/dW7pGoxMRHIIDsRAQh Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2009-10-01 at 12:33 +0200, Dag-Erling Sm=C3=B8rgrav wrote: > Coleman Kane writes: > > - if (sc->ndis_80211 && vap) > > + if ((sc->ndis_80211 !=3D NULL) && (vap !=3D NULL)) >=20 > sc->ndis_80211 is an int. NULL is a pointer. >=20 > DES Thanks, fix committed... I know style(9) says I should have not bothered with the commit, but the assume-that-zero-is-false logic seemed egregious enough at the time to warrant correcting it. I just corrected it improperly in my haste. Enjoy being able to buildkernel again. I'll be sitting in the corner. --=20 Coleman Kane --=-Y/dW7pGoxMRHIIDsRAQh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (FreeBSD) iEYEABECAAYFAkrEpxkACgkQcMSxQcXat5eI4gCfSHbYhuNGf1ODEmDWyLVDy1R1 qGIAn2uu7dzSTuNFx5/EsIVSdhp4rxZ9 =Eu+W -----END PGP SIGNATURE----- --=-Y/dW7pGoxMRHIIDsRAQh--