From owner-freebsd-net  Sun Oct 13 13:30:14 2002
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id D6DDD37B401
	for <net@FreeBSD.ORG>; Sun, 13 Oct 2002 13:30:13 -0700 (PDT)
Received: from InterJet.dellroad.org (adsl-63-194-81-26.dsl.snfc21.pacbell.net [63.194.81.26])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 4C16943E4A
	for <net@FreeBSD.ORG>; Sun, 13 Oct 2002 13:30:13 -0700 (PDT)
	(envelope-from archie@dellroad.org)
Received: from arch20m.dellroad.org (arch20m.dellroad.org [10.1.1.20])
	by InterJet.dellroad.org (8.9.1a/8.9.1) with ESMTP id NAA12265;
	Sun, 13 Oct 2002 13:24:35 -0700 (PDT)
Received: from arch20m.dellroad.org (localhost [127.0.0.1])
	by arch20m.dellroad.org (8.12.6/8.12.6) with ESMTP id g9DKNFON074921;
	Sun, 13 Oct 2002 13:23:15 -0700 (PDT)
	(envelope-from archie@arch20m.dellroad.org)
Received: (from archie@localhost)
	by arch20m.dellroad.org (8.12.6/8.12.6/Submit) id g9DKNF4C074920;
	Sun, 13 Oct 2002 13:23:15 -0700 (PDT)
From: Archie Cobbs <archie@dellroad.org>
Message-Id: <200210132023.g9DKNF4C074920@arch20m.dellroad.org>
Subject: Re: Comments Please
In-Reply-To: <20021012.171809.93306957.imp@bsdimp.com> "from M. Warner Losh at
 Oct 12, 2002 05:18:09 pm"
To: "M. Warner Losh" <imp@bsdimp.com>
Date: Sun, 13 Oct 2002 13:23:15 -0700 (PDT)
Cc: net@FreeBSD.ORG
X-Mailer: ELM [version 2.4ME+ PL88 (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
Sender: owner-freebsd-net@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-net.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-net>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-net>
X-Loop: FreeBSD.org

M. Warner Losh writes:
>  
>  static	int ether_resolvemulti(struct ifnet *, struct sockaddr **,
>  		struct sockaddr *);
> -u_char	etherbroadcastaddr[6] = { 0xff, 0xff, 0xff, 0xff, 0xff, 0xff };
> +u_char	etherbroadcastaddr[ETHER_ADDR_LEN] = 
> +    { 0xff, 0xff, 0xff, 0xff, 0xff, 0xff };

'etherbroadcastaddr' should really have type 'const u_char []'
rather than 'u_char []'.

-Archie

__________________________________________________________________________
Archie Cobbs     *     Packet Design     *     http://www.packetdesign.com

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message