From owner-freebsd-current@FreeBSD.ORG Thu Dec 4 15:34:42 2008 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E16181065679 for ; Thu, 4 Dec 2008 15:34:42 +0000 (UTC) (envelope-from onemda@gmail.com) Received: from yx-out-2324.google.com (yx-out-2324.google.com [74.125.44.28]) by mx1.freebsd.org (Postfix) with ESMTP id 9069C8FC0C for ; Thu, 4 Dec 2008 15:34:42 +0000 (UTC) (envelope-from onemda@gmail.com) Received: by yx-out-2324.google.com with SMTP id 8so1747753yxb.13 for ; Thu, 04 Dec 2008 07:34:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=T7bwJO05RRjcmjeg59bWYmpM+rH0ZpL1m1JZSIed0YY=; b=RqES+H2ohJeNexul4eDON7X64IyfHKtAs+mLC5xf26M1ItXGbLmzxZet+9zkl7UtW0 MuyWsySTRTDM+KoyoVKVKcIl09IVRUdHNZZXCfDqZkg+qktb75XGV8nyluPESFp1zW2t 4zmK6TYHwpBZLoPlJ40ggfJj+bZbXdfWpuYcQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=Ve2RZtXtzPyRd23JaSbfrF24SH8aN1yAsr/do95O2+WhJbHs47FKiwSciqyrFVjHtu I8XmihBYTKv9tElxHuJvfhPLIvipeawc0iBCt8Aiv+AXbxsntsrDadxdgwtsehTCcHhx yGsKHNbR2X6DKShOGgb2nflXJPfK2dUZgNq8s= Received: by 10.231.20.70 with SMTP id e6mr82795ibb.56.1228404881291; Thu, 04 Dec 2008 07:34:41 -0800 (PST) Received: by 10.231.13.138 with HTTP; Thu, 4 Dec 2008 07:34:41 -0800 (PST) Message-ID: <3a142e750812040734g26ecda23pfe646c27521cdc82@mail.gmail.com> Date: Thu, 4 Dec 2008 16:34:41 +0100 From: "Paul B. Mahol" To: "Maksim Yevmenkin" In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <7d6fde3d0812040324y3bf0901cy1f4a6d961362c314@mail.gmail.com> Cc: Garrett Cooper , "current@freebsd.org" Subject: Re: RFC: small syscons and kbd patch X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Dec 2008 15:34:43 -0000 On 12/4/08, Maksim Yevmenkin wrote: > On Thu, Dec 4, 2008 at 3:24 AM, Garrett Cooper wrote: >> On Tue, Dec 2, 2008 at 5:01 PM, Maksim Yevmenkin >> wrote: >>> Dear Hackers, >>> >>> can someone please review the attached small patch for syscons and >>> kbd? it should be a no-op mostly. the patch basically does >>> >>> 1) removes bogus layering in syscons, i.e. basically removes sccngetch(); >>> 2) implements advisory lock for kbd (based on atomic(9)); >>> 3) implements new POLLED flag for kbd; >>> >>> this is a part of a plan to fix keyboard access races in syscons. >>> >>> thanks, >>> max >> >> Max, >> Why are you double and triple negating on this line? >> >> + return (atomic_cmpset_acq_int(&kbd->kb_locked, !!!on, !!on)); > > the idea was to ensure that kbd->kb_locked variable only takes values > 0 (zero) and 1 (one). > > thanks, > max > _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" > Maybe it is usefull to report, maybe not. I'm experiencing keyboard (atkbd) death now and then when inside Xorg once Xorg is started in following (racey) way: alias onlyx "/usr/local/bin/xinit -- -nolisten tcp -br & && exit" and /etc/csh.logout: echo $TERM | grep cons25 >> /dev/null && clear && vidcontrol -C I will test it and report if it fix my "problem". -- Paul