From owner-cvs-all Wed Jan 27 20:04:42 1999 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id UAA04403 for cvs-all-outgoing; Wed, 27 Jan 1999 20:04:42 -0800 (PST) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.26.10.9]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id UAA04388; Wed, 27 Jan 1999 20:04:37 -0800 (PST) (envelope-from bde@godzilla.zeta.org.au) Received: (from bde@localhost) by godzilla.zeta.org.au (8.8.7/8.8.7) id PAA32241; Thu, 28 Jan 1999 15:04:35 +1100 Date: Thu, 28 Jan 1999 15:04:35 +1100 From: Bruce Evans Message-Id: <199901280404.PAA32241@godzilla.zeta.org.au> To: cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, dillon@FreeBSD.ORG Subject: Re: cvs commit: src/sys/dev/smbus smbconf.h Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk > Modified files: > sys/dev/smbus smbconf.h > Log: > Add parens to SMBPRI, fixing bug in tsleep() call that OR's SMBPRI with > something else. Not actually fixing anything, since '+' has much higher precedence than '|'. I agree that not parenthesizing these operators in expressions where they occur explicitly is a style bug. Not parenthesizing SMBPRI was just a bug. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message