Date: Thu, 22 Dec 2011 14:05:14 GMT From: Oliver Heesakkers <dev2@heesakkers.info> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/163534: [patch] /audio/clementine-player add option for lastfm (and thus ruby) Message-ID: <201112221405.pBME5EaB017554@red.freebsd.org> Resent-Message-ID: <201112221410.pBMEAB58098183@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 163534
>Category: ports
>Synopsis: [patch] /audio/clementine-player add option for lastfm (and thus ruby)
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Thu Dec 22 14:10:11 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator: Oliver Heesakkers
>Release: 9.0-RC3 amd64
>Organization:
>Environment:
>Description:
I'm trying to keep my system(s) free of ruby. The most recent update of clementine-player however pulls in ruby through the Last.fm service.
Clementine-player will successfully build when audio/liblastfm is not installed, so simply moving that LIB_DEPEND into an option makes it easily possible to avoid having to build ruby.
Since lastfm was heretofore automatic, I defaulted the option to on
>How-To-Repeat:
Do not have ruby installed. Start the installation of clementine-player and watch it pulling in ruby.
>Fix:
diff -ruN clementine-player.orig/Makefile clementine-player/Makefile
--- clementine-player.orig/Makefile 2011-12-21 05:24:01.000000000 +0100
+++ clementine-player/Makefile 2011-12-22 14:52:04.000000000 +0100
@@ -17,8 +17,7 @@
LICENSE= GPLv3
-LIB_DEPENDS= lastfm.0:${PORTSDIR}/audio/liblastfm \
- tag.1:${PORTSDIR}/audio/taglib \
+LIB_DEPENDS= tag.1:${PORTSDIR}/audio/taglib \
notify.4:${PORTSDIR}/devel/libnotify \
xine.1:${PORTSDIR}/multimedia/libxine \
mtp:${PORTSDIR}/audio/libmtp
@@ -37,7 +36,8 @@
USE_GSTREAMER= gio ogg mp3 flac soup vorbis
MAKE_JOBS_UNSAFE= yes
-OPTIONS= VISUALISATION "Visualisations from projectM" off
+OPTIONS= VISUALISATION "Visualisations from projectM" off \
+ LASTFM "Support Last.fm service (requires ruby)" on
.include <bsd.port.pre.mk>
@@ -48,4 +48,8 @@
PLIST_SUB+= VSL="@comment "
.endif
+.if defined(WITH_LASTFM)
+LIB_DEPENDS+= lastfm.0:${PORTSDIR}/audio/liblastfm
+.endif
+
.include <bsd.port.post.mk>
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201112221405.pBME5EaB017554>