From owner-freebsd-www Wed Nov 6 21:20: 7 2002
Delivered-To: freebsd-www@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
by hub.freebsd.org (Postfix) with ESMTP id 20E5B37B401
for <freebsd-www@hub.freebsd.org>; Wed, 6 Nov 2002 21:20:03 -0800 (PST)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
by mx1.FreeBSD.org (Postfix) with ESMTP id 1D2DB43E6E
for <freebsd-www@hub.freebsd.org>; Wed, 6 Nov 2002 21:20:02 -0800 (PST)
(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
by freefall.freebsd.org (8.12.6/8.12.6) with ESMTP id gA75K2x3029484
for <freebsd-www@freefall.freebsd.org>; Wed, 6 Nov 2002 21:20:02 -0800 (PST)
(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
by freefall.freebsd.org (8.12.6/8.12.6/Submit) id gA75K1TV029483;
Wed, 6 Nov 2002 21:20:01 -0800 (PST)
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
by hub.freebsd.org (Postfix) with ESMTP id C50C137B401
for <FreeBSD-gnats-submit@FreeBSD.org>; Wed, 6 Nov 2002 21:19:06 -0800 (PST)
Received: from mail.soaustin.net (mail.soaustin.net [207.200.4.66])
by mx1.FreeBSD.org (Postfix) with ESMTP id EC42343E3B
for <FreeBSD-gnats-submit@FreeBSD.org>; Wed, 6 Nov 2002 21:19:05 -0800 (PST)
(envelope-from linimon@lonesome.com)
Received: from lonesome.lonesome.com (cs2876-77.austin.rr.com [24.28.76.77])
by mail.soaustin.net (Postfix) with ESMTP id 2B4961431B
for <FreeBSD-gnats-submit@FreeBSD.org>; Wed, 6 Nov 2002 23:18:59 -0600 (CST)
Received: from lonesome.lonesome.com (localhost.lonesome.com [127.0.0.1])
by lonesome.lonesome.com (8.12.6/8.12.3) with ESMTP id gA76IgIm008876
for <FreeBSD-gnats-submit@FreeBSD.org>; Thu, 7 Nov 2002 00:18:43 -0600 (CST)
(envelope-from linimon@lonesome.lonesome.com)
Received: (from linimon@localhost)
by lonesome.lonesome.com (8.12.6/8.12.6/Submit) id gA76IgwE008875;
Thu, 7 Nov 2002 00:18:42 -0600 (CST)
(envelope-from linimon)
Message-Id: <200211070618.gA76IgwE008875@lonesome.lonesome.com>
Date: Thu, 7 Nov 2002 00:18:42 -0600 (CST)
From: Mark Linimon <linimon@lonesome.com>
To: FreeBSD-gnats-submit@FreeBSD.org
X-Send-Pr-Version: 3.113.1
Subject: www/45021: processlogs script does not produce valid HTML
Sender: owner-freebsd-www@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-www.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-www>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-www>
X-Loop: FreeBSD.org
>Number: 45021
>Category: www
>Synopsis: processlogs script does not produce valid HTML
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-www
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Wed Nov 06 21:20:01 PST 2002
>Closed-Date:
>Last-Modified:
>Originator: Mark Linimon
>Release: FreeBSD-4.6
>Organization:
FreeBSD
>Environment:
N/A
>Description:
There is neither a closing body tag nor a closing html tag. In
general, browsers work without these, but Konqueror in particular
was displaying some artifacts.
While I was in there, also made sure empty cells had an nbsp
directive; eliminated a bogus case for Aff.; and changed Date
build to Build date, which seems more grammatical to me.
These diffs are complementary to the ones in www/44919.
Either or both may be used.
>How-To-Repeat:
N/A
>Fix:
--- processlogs.dist Sun Nov 3 19:06:44 2002
+++ processlogs Wed Nov 6 23:54:57 2002
@@ -173,10 +173,16 @@
fi
}
+footer() {
+ echo "</table>" >>$of
+ echo "</body>" >>$of
+ echo "</html>" >>$of
+}
+
#
# Create "default" output, sorted on portname
#
-header "<th>Port</th><th>Aff.</th><th>Size</th><th>CVS</th><th>Maintainer</th><th>Reason</th><th>Date build</th>"
+header "<th>Port</th><th>Aff.</th><th>Size</th><th>CVS</th><th>Maintainer</th><th>Reason</th><th>Build date</th>"
for i in `cat .logs | sort`; do
set $(echo $i | tr \| " ")
@@ -184,7 +190,7 @@
echo "<td><a href=\"$1\">$2</a></td>" >> $of
affby=$3
- test $affby = "0" && affby=""
+ test $affby = "0" -o $affby = "-1" && affby=" "
echo "<td align=\"right\">$affby</td><td align=\"right\">$4 Kb</td>" >> $of
echo "<td><a href=\"http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/$5\">$5</a></td>" >> $of
echo "<td><a href=\"mailto:$6\">$6</a></td>" >> $of
@@ -200,13 +206,13 @@
echo "</tr>" >> $of
done
-echo "</table>" >> $of
+footer ""
mv -f $of index.html
#
# Create output by category
#
-header "<th>CVS</th><th>Aff.</th><th>Size</th><th>Port</th><th>Maintainer</th><th>Reason</th><th>Date build</th>"
+header "<th>CVS</th><th>Aff.</th><th>Size</th><th>Port</th><th>Maintainer</th><th>Reason</th><th>Build date</th>"
for i in `cat .logs | sort -t \\| +4`; do
set $(echo $i | tr \| " ")
@@ -214,7 +220,7 @@
echo "<td><a href=\"http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/$5\">$5</a></td>" >> $of
affby=$3
- test $affby = "0" && affby=""
+ test $affby = "0" -o $affby = "-1" && affby=" "
echo "<td align=\"right\">$affby</td><td align=\"right\">$4 Kb</td>" >> $of
echo "<td><a href=\"$1\">$2</a></td>" >> $of
echo "<td><a href=\"mailto:$6\">$6</a></td>" >> $of
@@ -230,13 +236,13 @@
echo "</tr>" >> $of
done
-echo "</table>" >> $of
+footer ""
mv -f $of index-category.html
#
# Create output by maintainer
#
-header "<th>Maintainer</th><th>Port</th><th>Aff.</th><th>Size</th><th>CVS</th><th>Reason</th><th>Date build</th>"
+header "<th>Maintainer</th><th>Port</th><th>Aff.</th><th>Size</th><th>CVS</th><th>Reason</th><th>Build date</th>"
for i in `cat .logs | sort -t \\| +5`; do
set $(echo $i | tr \| " ")
@@ -245,7 +251,7 @@
echo "<td><a href=\"$1\">$2</a></td>" >> $of
affby=$3
- test $affby = "0" && affby=""
+ test $affby = "0" -o $affby = "-1" && affby=" "
echo "<td align=\"right\">$affby</td><td align=\"right\">$4 Kb</td>" >> $of
echo "<td><a href=\"http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/$5\">$5</a></td>" >> $of
@@ -260,13 +266,13 @@
echo "</tr>" >> $of
done
-echo "</table>" >> $of
+footer ""
mv -f $of index-maintainer.html
#
# Create output by error
#
-header "<th>Reason</th><th>Port</th><th>Aff.</th><th>Size</th><th>CVS</th><th>Maintainer</th><th>Date build</th>"
+header "<th>Reason</th><th>Port</th><th>Aff.</th><th>Size</th><th>CVS</th><th>Maintainer</th><th>Build date</th>"
for i in `cat .logs | sort -t \\| +7`; do
set $(echo $i | tr \| " ")
@@ -281,7 +287,7 @@
echo "<td><a href=\"$1\">$2</a></td>" >> $of
affby=$3
- test $affby = "0" && affby=""
+ test $affby = "0" -o $affby = "-1" && affby=" "
echo "<td align=\"right\">$affby</td><td align=\"right\">$4 Kb</td>" >> $of
echo "<td><a href=\"http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/$5\">$5</a></td>" >> $of
echo "<td><a href=\"mailto:$6\">$6</a></td>" >> $of
@@ -291,13 +297,13 @@
echo "</tr>" >> $of
done
-echo "</table>" >> $of
+footer ""
mv -f $of index-reason.html
#
# Create output by builddate
#
-header "<th>Date build</th><th>Port</th><th>Aff.</th><th>Size</th><th>CVS</th><th>Maintainer</th><th>Reason</th>"
+header "<th>Build date</th><th>Port</th><th>Aff.</th><th>Size</th><th>CVS</th><th>Maintainer</th><th>Reason</th>"
for i in `cat .logs | sort -t \\| +9`; do
set $(echo $i | tr \| " ")
@@ -309,7 +315,7 @@
echo "<td><a href=\"$1\">$2</a></td>" >> $of
affby=$3
- test $affby = "0" && affby=""
+ test $affby = "0" -o $affby = "-1" && affby=" "
echo "<td align=\"right\">$affby</td><td align=\"right\">$4 Kb</td>" >> $of
echo "<td><a href=\"http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/$5\">$5</a></td>" >> $of
echo "<td><a href=\"mailto:$6\">$6</a></td>" >> $of
@@ -322,7 +328,7 @@
echo "</tr>" >> $of
done
-echo "</table>" >> $of
+footer ""
mv -f $of index-builddate.html
#
>Release-Note:
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-www" in the body of the message