From nobody Wed May 25 15:39:20 2022 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 8FBF81B42E58 for ; Wed, 25 May 2022 15:39:21 +0000 (UTC) (envelope-from matteo@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4L7ZxP3S7Zz4YqP; Wed, 25 May 2022 15:39:21 +0000 (UTC) (envelope-from matteo@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1653493161; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=90CYH08vwNbwvExKpyGPSy5g34Bp2yXKzfvTgUaTRro=; b=g8ogUjpP1HQRt6Y8m7bPPu8VSUC2XzreecjffUa5OQGFcUzqwaFrIjrDuyWKTod6f4pncI AFpulKyclme2c2bCjmo7t1UE64JHQ2Oz3IF/376G96ps1l3kghYgQH2oyplcWqnSmzEzrU ePKIMe34UPmBIIosLu6FJGODgTTzbOZKDC8wIeO6Bk+V2twM2SlwIrSYwRbrswy3jtWmKz DkDNpSNVL/M3BoBP1JCXU5gBZ5xAfhbfvJsktxNyDTGOlpARPNT6y5pkw8SgBwEXxFt7va IJx2vYbiXgqbsuVfhCWhZhKYhzOWD2j85+sZOZ2RBofC3k/t0Clxk4+EsXp8kA== Received: from ubertino.local (unknown [IPv6:2601:19b:4400:1779::107b]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: matteo/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 072CBDF99; Wed, 25 May 2022 15:39:20 +0000 (UTC) (envelope-from matteo@freebsd.org) Date: Wed, 25 May 2022 11:39:20 -0400 From: Matteo Riondato To: Warner Losh Cc: matti k , Alexander Motin , FreeBSD Current , Jim Harris Subject: Re: nvme INVALID_FIELD in dmesg.boot Message-ID: <20220525153920.sxzi7fhsfzv6yidv@ubertino.local> X-PGP-Key: http://rionda.to/files/matteogpg.asc References: <20220525122529.t2kwfg2q65dfiyyt@host-ubertino-mac-88e9fe7361f5.eduroam.ssid.10net.amherst.edu> <20220526001715.4ffee96a@ws1.wobblyboot.net> List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="65nvyd67luamsejh" Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1653493161; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=90CYH08vwNbwvExKpyGPSy5g34Bp2yXKzfvTgUaTRro=; b=gwYjzslrqNL/tMwS9B4zJJzfRo1qTk2GoMNfcoXHfUnDjWxKvv6iQtJOKgyxapWaOFePgo wIRqBDs1+W6W5CdaWLXt9q0x2yxKF19/1egE7WIs3WRo3wcZ94l/lGtLJY3j+e0zjPmXrE 0UC/CUWWlst6lOEf65cfZi4inn82EZG7TwKTN/ztE7CRG2ij2Sn0M7O2W+nUUmniVJBuTu m2r752MorIb09rfXVETVMAqdkK2cUa7PMAAOD2K6F4HqrDVArL7Krj9cV6HJb+GxifdRz0 tHjObYiWartRcH6zf7RInc8fI/HGlofNJ0hZ1vat9CclOeBG/JqJ4oEnTueO6w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1653493161; a=rsa-sha256; cv=none; b=lHPUAo7KKqewQlYlLnsO/MMwtEWBNIL7l+2NKqiR2SUHcXA3aycZ0AfAjpk2tSe3mE6RMO mVjMk6L/OhEacALv3Ob9I83Mqj9Yx/PAoWp72tJjIy0f/5VDCOcGRxjMvvgzhM+1cBSxOQ pa5A1nSR1uGImqjNymop8TZwZwl9CFT7X0h3KOiYpd9rLMoYvHLAhYjmMSdjZhctKdnD80 /NXbVuDvQ6cesIC0PHFLknL7P12FcAO/BAd5RwFqskbDMPgXFUsLttS5fqcdaFqJV3Fig6 GMzU11FqV4rhnVCMBs5M8KGQ5JBjDX76/ZItR3K/wj9KLckcbdqAm9UR/85i2A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N --65nvyd67luamsejh Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2022-05-25 at 11:29 EDT, Warner Losh wrote: > >SET FEATURES (opcode 9) feature 0xb is indeed async event=20 >configuration. >0x31f is: >SMART WARNING for available spares (0x1) >SMART warning for temperature (0x2) >SMART WARNING for device reliability (0x4) >SMART WARNING for being read only (0x8) >SMART WARNING for volatile memory backup (0x10) >Namespace attribute change events (0x100) >Firmware activation events (0x200) > >I wonder which one of those it doesn't like. My reading of the standard=20 >suggests that those should always be supported for a 1.2 and later=20 >drive... Thought maybe with the possible exception of the volatile=20 >memory backup, so let me do some digging here... > >We can get the last two items from OAES field of the controller=20 >identificaiton data. This is bytes 95:92, which if I'm counting right=20 >is the last word on the 040: line in the nvmecontrol identify -x nvmeX=20 >command: > >040: 4e474e4b 30303150 000cca07 00230000 00010200 005b8d80 0030d400=20 >00000100 >--------------------------------------------------------------------------= --------------------------------^^^^^^^^^ On my system: 040: 31564456 30373130 5cd2e400 00000500 00010200 001e8480 002dc6c0=20 00000200 (same for all nvmeX, as far as I can tell) >It looks like we don't currently test these bits before we add the last=20 >two (we do it unconditionally for >=3D 1.2, and maybe we should check=20 >these bits >=3D 1.2). > >Would you be able to test a fix for this? Yes, I would be happy to, but I cannot do it for a couple of weeks=20 (running simulations for a deadline). Thanks, Matteo --65nvyd67luamsejh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJHBAABCgAxFiEEa9uKZL0hP4E8Nl5vGwL9SVQlVQEFAmKOTacTGGhrcHM6Ly9w Z3AubWl0LmVkdQAKCRAbAv1JVCVVAQrmEADq3C7OD4UXRghoDttG3XOiFuRY2zY7 y6w6zZpAdlVw3wadHyW0yZ+UR5KdnnoSUnM99vDy8dxsPQ/xyuSb/sK6INENlX6t 2xFyP8OL4MQxdp0c17Pc9+MpU//nderecivMr4oB5HznipRuGl430SKTkk7/kIWw 0lSGUkfYDu+FLKg8TJNyJ9LCm3lCGA2tESOI4DJ9IDhSvQwnWskJJb0hOwB2TxiR FjpYpIn2erLfauCidNIJSz1ieNYjl9iSCdzIjZm4WZ97xM3kJ27fouIATz6b8g+3 p+aW6srN3GBKr7uh9W5igH+4MSa9bYl6N0/tqA8tODOyq7yai/MIlAG7ZOpG42zr EDJq5EbUY4yiL7KXrcbECir6uaYQmk5JBh626LcN1zWHBbrVWE/+va2s/xxuqBQg 2f7BFkhjH3TafHlBq+cTO8s8iGGXSjj7QVBQFXutkkye0t+LiFvdZH/IOfJaK2N/ l9JwA0rR/a6e6evAgM6vwAmfSmxLS7FcaujEfm7uMKCX5eAhWRA9tmNt698Rw+vd h53ZRPu9JBq0RB5UUzZiEecZX9OguvoWE4iTNPNw8OaiJJzjoaebY234ug+IDVeJ zqfT10DWxzrOsjQwYWBY1xdDKurAkXktuB3YTYUNUlC0bP+D7Tgsq3V+c9/t0S9c FT8x/l4n9fxp+A== =Y3uD -----END PGP SIGNATURE----- --65nvyd67luamsejh--