Date: Mon, 4 Jan 2010 12:37:19 -0600 From: Brooks Davis <brooks@freebsd.org> To: freebsd-hackers@freebsd.org Subject: testing needed: Secure RPC Message-ID: <20100104183719.GA16422@lor.one-eyed-alien.net>
next in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
I've got a patch against the Secure RPC code which replaces an
apparently bogus use of NGROUPS and fixes a bug where the internal
identify cache stores uid_t and gid_t data in shorts. It's trivial and
it looks like all the surrounding uses do use the correct size and just
discard data when passing it through the cache, but I don't have an easy
way to test it. Does anyone else?
-- Brooks
Index: lib/libc/rpc/svc_auth_des.c
===================================================================
--- lib/libc/rpc/svc_auth_des.c (revision 201441)
+++ lib/libc/rpc/svc_auth_des.c (working copy)
@@ -449,10 +449,10 @@
#define INVALID -1 /* grouplen, if cache entry is invalid */
struct bsdcred {
- short uid; /* cached uid */
- short gid; /* cached gid */
- short grouplen; /* length of cached groups */
- short groups[NGROUPS]; /* cached groups */
+ uid_t uid; /* cached uid */
+ gid_t gid; /* cached gid */
+ int grouplen; /* length of cached groups */
+ gid_t groups[NGRPS]; /* cached groups */
};
/*
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (FreeBSD)
iD8DBQFLQjVfXY6L6fI4GtQRAvoDAKCQVyzET+tUZVTm4lgNPGugdJhmoACeJbAy
aOm02jIw+xVyhugOQWfSu2w=
=oSRg
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100104183719.GA16422>