From owner-cvs-all@FreeBSD.ORG Wed Jul 25 06:48:33 2007 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DAA5716A419; Wed, 25 Jul 2007 06:48:33 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id CF04E13C491; Wed, 25 Jul 2007 06:48:33 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l6P6mXbW066991; Wed, 25 Jul 2007 06:48:33 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l6P6mX6o066990; Wed, 25 Jul 2007 06:48:33 GMT (envelope-from imp) Message-Id: <200707250648.l6P6mX6o066990@repoman.freebsd.org> From: Warner Losh Date: Wed, 25 Jul 2007 06:48:33 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/usb ukbd.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Jul 2007 06:48:34 -0000 imp 2007-07-25 06:48:33 UTC FreeBSD src repository Modified files: sys/dev/usb ukbd.c Log: Fix absolutely maddening autorepeat bug that would cause the last key to repeat if you had more than two keys down at any given time (which happened to me all the time with emacs). This is taken from PR 110681, although what URATAN Shigenobu describes there is different than the pathology that I have been seeing. I'm seeing this only in X, while he sees it on his console, yet I think the two problems are related. I've also reworked the patch slightly to conform to the coding standards of adjacent code. It is unclear to me if this merely masks the maddening bug that I have seen, or if this is a real fix. I typically see the problem when I'm typing fast in emacs and using lots of motion keys (meta and control). In either case, my workstation at work again is finally useful with this patch. PR: 110681 Submitted by: URATAN Shigenobu Approved by: re (blanket) Revision Changes Path 1.72 +9 -0 src/sys/dev/usb/ukbd.c