From nobody Wed Feb 26 23:55:34 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Z3BDn1dJKz5pChK; Wed, 26 Feb 2025 23:55:37 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Z3BDn15f5z3w6f; Wed, 26 Feb 2025 23:55:37 +0000 (UTC) (envelope-from glebius@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1740614137; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=n7SW/UvcJkTk4xF4ffRVnl9NtcsbSYoaE/5bqjKcbf4=; b=R2RVTXqlnZsd07ym22PaNs+ogA8dp/0ICgegc+v/vhHaHnd4mvFv/vN0BMd90kfkf7TGoF jXOlAPGfDVuaxrPPPjr9wk4qzNaEIYLG+TnaA2Z0FkoLzGecVb1xWc29l4k11GyR8b7Z6F N459F9OQwP8mZVzs8Cw4ZXvouBZ/HvoAca73km3+RcTFJgHWW4BC/3Ac2IpPS1zqNkWNzk gKdN8lb6pr8up8G3F3E5suxbFxQcZwFkPyJB/vjQDSnE4rHl5n01UMhxMIHMugtaslQsoN heYV+6J9Zzf401FZP7T6dBcDYaAigIWGMdWqpCh7qgPHei3ww0p+uUbd8uai7g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1740614137; a=rsa-sha256; cv=none; b=RoeBRrczpp1ieRuRpSN3nKctfHVyYD8+1Z+Z8JA5OqTppinJoZAjzLDzzmmotzpUzmaAYP xEMWG/dWE5LMu/hOUVXzt8PwyuorGZmH4BQgHDKHHS3bfeaIC81GazQNu2UT0QT9Ds1fKp itSvMzl7jKOA6bl/lHf1W8Bn90AwMM+4/O/ToAgAgJzvKDQwi0d+YHW5uWA3Qx3iwNjrg6 NXfxZnfX1mZ20VzR7OMYKLZu3hVliY93l7wdM5ZmbtuFefrncrBOpK7nbiwT/t9dMEkmxY 7iSQPhH4W3v3kWxhdrOh/bbxKB2uU+MV/BKh84DJUFE+lcqdur5j7R6COsY9Pg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1740614137; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=n7SW/UvcJkTk4xF4ffRVnl9NtcsbSYoaE/5bqjKcbf4=; b=jIFuAAw04kRKz1Jh+DzylAIErSKk3qQgctW4qt/qm/K4hP3x42M7YrYTeU7WZ4tXdCLaHc aZzWFY8ZNPTlt9aogt98CCaSkt2jo1MS2xDRMY1MZSguglaI9d9zbB+pm3C/w+ZbU8XzDI dQg/ikDa0I1MZLhZ1nrbHN0H+Byqrp2Z2seoGNDzen8I+V+4pg+SmExDRG4NFdzeJNfsn+ gHlS6nZDSnMcwmXrpnIISqBQIYqQU80yFgtZXmUsL2wBKpdEI50y81N9KDmvdtPg2hf+yA 9cChiVYb1nLV3vM9nC+3U/Nj3ECGtLtkWyJi9a80SHsvlVno+YVIX1gOm45pBg== Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: glebius) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Z3BDm3JxJz16Lp; Wed, 26 Feb 2025 23:55:36 +0000 (UTC) (envelope-from glebius@freebsd.org) Date: Wed, 26 Feb 2025 15:55:34 -0800 From: Gleb Smirnoff To: "Bjoern A. Zeeb" Cc: Michael Tuexen , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 0e58542fd246 - main - tcp: remove unused field from struct tcpcb Message-ID: References: <202502252048.51PKm4YX061305@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Feb 26, 2025 at 02:23:46AM +0000, Bjoern A. Zeeb wrote: B> > --- a/sys/netinet/tcp_var.h B> > +++ b/sys/netinet/tcp_var.h B> > @@ -452,7 +452,6 @@ struct tcpcb { B> > tcp_seq gput_seq; /* Outbound measurement seq */ B> > tcp_seq gput_ack; /* Inbound measurement ack */ B> > int32_t t_stats_gput_prev; /* XXXLAS: Prev gput measurement */ B> > - uint32_t t_maxpeakrate; /* max peak rate set by user, bytes/s */ B> B> Is the tcpcb no longer KBI relevant these days? B> In the old days we'd simply make this a spare and not move all offsets B> below around. In the old days tcpcb was visible to userland, that's why there was the spare habit. On FreeBSD CURRENT we don't provide KBI stability between core network stack and advanced TCP stacks as loadable modules, neither NIC driver modules that meddle with TCP. -- Gleb Smirnoff