From owner-cvs-all@FreeBSD.ORG  Mon Oct 10 14:33:48 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
	id 17B7916A420; Mon, 10 Oct 2005 14:33:48 +0000 (GMT)
Date: Mon, 10 Oct 2005 14:33:48 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Jean-Marc Zucconi <jmz@FreeBSD.org>
Message-ID: <20051010143348.GA28711@FreeBSD.org>
References: <200510101133.j9ABXWg4000289@repoman.freebsd.org>
	<20051010125906.GA3640@FreeBSD.org>
	<200510101424.j9AEOdFW086853@freefall.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <200510101424.j9AEOdFW086853@freefall.freebsd.org>
User-Agent: Mutt/1.4.2.1i
Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/games/doom Makefile ports/games/doom/files
	patch-ag patch-sndserv__soundsrv.c patch-sndserv__wadread.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 10 Oct 2005 14:33:48 -0000

On Mon, Oct 10, 2005 at 02:24:39PM +0000, Jean-Marc Zucconi wrote:
> >>>>> Alexey Dokuchaev writes:
> 
>  > On Mon, Oct 10, 2005 at 11:33:31AM +0000, Jean-Marc Zucconi wrote:
>  >> jmz         2005-10-10 11:33:30 UTC
>  >> 
>  >> FreeBSD ports repository
>  >> 
>  >> Modified files:
>  >> games/doom           Makefile 
>  >> games/doom/files     patch-ag 
>  >> Added files:
>  >> games/doom/files     patch-sndserv__soundsrv.c 
>  >> patch-sndserv__wadread.c 
>  >> Log:
> 
>  > 	...
> 
>  >> Replace post-patch with real patch files.
> 
>  > I've always been under impression that we try to avoid creating trivial
>  > patches when desired functionality can be implemented using some
>  > inplace-editing tools.  Could you elaborate on what you've done here?
> 
> I don't know if there is a rule. As the changes are on two files only
> I decided to not alter the submitted patch and to commit it as is. In
> either case this will not cause maintenance problems because the port
> probably will never be upgraded.

Please excuse me if I was overly touched be this, frankly, minor issue.
My point was merely saving couple of inodes in the repo.  :-)

./danfe