From owner-svn-src-head@freebsd.org Tue Jan 10 23:14:13 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C995CCA97A5; Tue, 10 Jan 2017 23:14:13 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-wm0-x242.google.com (mail-wm0-x242.google.com [IPv6:2a00:1450:400c:c09::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5FBF5101C; Tue, 10 Jan 2017 23:14:13 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by mail-wm0-x242.google.com with SMTP id r144so24393337wme.0; Tue, 10 Jan 2017 15:14:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=UpNuHVgeqMsT2Mq8GPzbfer4xL7RvC7CMabmXaXLgSU=; b=TU+icee8yK5Hw4dybjdgR1ebvS3ZVuu27NtbAwchHYw3lwHN4IeTwuaqDzIro8YSMx UKV9XGjEjuTnTHUITapw1HCunOmlRm49i5839M7k858FOgbclW0efyuT/OZYBHEgFFaR zkeM/sm8NLlTkp6/M5LaX3pvCwORImEbJDfIp/XKmB6HOMr+i9HkfOyjI4YXEVaS50ER mvXMXB1IVWm0PI6N7FbjXkL9i2VqrDhkDhA5npbHgh2d2HM0DjVZsTeEsqI9hfCauWgG D3osjhOgyNiKVpZ5k7E7Mo9BN7e35y0WLxDxKnSJdS4qkfh/UcXE2rLOpQ1r0IZL//AR jABQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=UpNuHVgeqMsT2Mq8GPzbfer4xL7RvC7CMabmXaXLgSU=; b=IDuTmtYFgldBkAx7HvOfAIZfS3lZE1bTs2ngmZt2QArFuwcOvJEvrHchafFkkpcrMv ywvl87dGlRessWTAoir1arACr6kji4h6JKkTx2iOwyZhOGc4wC17uOTJ6uBjwn+AU50b epbF17vs1wVC7HCPjmytPwq6D6Bmqvdxa6qi2hkwStg9VYONl7i035tU6GklvRzWsaxW nSZxvrRPVYPB57tb92oAlw2Ein4ptDKsR2lDjQ4HV4EhN8hJEK/GDG7QHvjDLOMkbV8W ue6dpR7A1070EOIgbWu45NqQ3tuS/cTA9UHQ5tlOP7y+gvhCsQexvxEHEgI2l0kQ7S6i tJGQ== X-Gm-Message-State: AIkVDXJn1LSoovZzxfFod5mZLKWGSl1kLUJnPJaxKZNzZL/tB6C6ym06lNCO8iinc9nNejmXPr/m+8gtZBTg8g== X-Received: by 10.28.139.131 with SMTP id n125mr1208353wmd.116.1484090051387; Tue, 10 Jan 2017 15:14:11 -0800 (PST) MIME-Version: 1.0 Sender: adrian.chadd@gmail.com Received: by 10.194.82.162 with HTTP; Tue, 10 Jan 2017 15:14:10 -0800 (PST) In-Reply-To: <20170110172336.phqcy57zszifujaj@mutt-hardenedbsd> References: <201701100721.v0A7L7ip039127@repo.freebsd.org> <20170110172336.phqcy57zszifujaj@mutt-hardenedbsd> From: Adrian Chadd Date: Tue, 10 Jan 2017 15:14:10 -0800 X-Google-Sender-Auth: Rq0o6j5g0NsNXFtyZWQjtO3qJ8I Message-ID: Subject: Re: svn commit: r311860 - head/sys/net80211 To: Shawn Webb Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jan 2017 23:14:13 -0000 Yeah, oops! Thanks for getting it fixed! -adrian On 10 January 2017 at 09:23, Shawn Webb wrote: > On Tue, Jan 10, 2017 at 07:21:07AM +0000, Adrian Chadd wrote: >> Author: adrian >> Date: Tue Jan 10 07:21:07 2017 >> New Revision: 311860 >> URL: https://svnweb.freebsd.org/changeset/base/311860 >> >> Log: >> [net80211] add VHT action frame placeholders for when it's time to implement. >> >> Modified: >> head/sys/net80211/ieee80211_vht.c >> >> Modified: head/sys/net80211/ieee80211_vht.c >> ============================================================================== >> --- head/sys/net80211/ieee80211_vht.c Tue Jan 10 05:37:53 2017 (r311859) >> +++ head/sys/net80211/ieee80211_vht.c Tue Jan 10 07:21:07 2017 (r311860) >> @@ -85,9 +85,49 @@ __FBSDID("$FreeBSD$"); >> * Look at mac80211/vht.c:ieee80211_vht_handle_opmode() for further details. >> */ >> >> +static int >> +vht_recv_action_placeholder(struct ieee80211_node *ni, >> + const struct ieee80211_frame *wh, >> + const uint8_t *frm, const uint8_t *efrm) >> +{ >> + >> + ieee80211_note(ni->ni_vap, "%s: called; fc=0x%.2x/0x%.2x", >> + __func__, >> + wh->i_fc[0], >> + wh->i_fc[1]); >> + >> + return (0); >> +} >> + >> +static int >> +vht_send_action_placeholder(struct ieee80211_node *ni, >> + int category, int action, void *arg0) >> +{ >> + >> + ieee80211_note(ni->ni_vap, "%s: called; category=%d, action=%d", >> + __func__, >> + category, >> + action); >> + return (EINVAL); >> +} >> + > > This broke the build for kernel configurations that don't have the > IEEE80211_DEBUG option set. ieee80211_note is only a valid function when > IEEE80211_DEBUG is defined. > > Thanks, > > -- > Shawn Webb > Cofounder and Security Engineer > HardenedBSD > > GPG Key ID: 0x6A84658F52456EEE > GPG Key Fingerprint: 2ABA B6BD EF6A F486 BE89 3D9E 6A84 658F 5245 6EEE