From owner-dev-commits-src-all@freebsd.org Wed Jan 13 11:13:45 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C53554D8452; Wed, 13 Jan 2021 11:13:45 +0000 (UTC) (envelope-from melounmichal@gmail.com) Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DG4ZK4pHCz4Vwd; Wed, 13 Jan 2021 11:13:45 +0000 (UTC) (envelope-from melounmichal@gmail.com) Received: by mail-wm1-x329.google.com with SMTP id g10so1241038wmh.2; Wed, 13 Jan 2021 03:13:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:reply-to:subject:to:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=UIwJJl1ZATE7qNfFfo3v9+gj9qwA5PqC1tnbSWqS4JQ=; b=iaNujW+qRJ2AtQawTxMMwrgzGKiIEJVm9k7KQRQPWmWz4PXhU1X7YIUW/qd++4RwYt ghVFtxRg3EzMBmM9F8JeFuQqrG55QcPJo59jj7ENkzlobfakxBRvaJlQYduUie6XGa5N p5SARBX4q8lO446L+EpF6A/KlOmygX/YzXrE2OeDj+QuUGcL420w9S5BcL8ysYIeplt2 BWXZy5DmwfoumhAHv3Joh3Tdcmz+rL0gCLqXCN2VAhWYwtiM82qwCKEgdIaB6eGvqsJM 5KD6wkU+sEWtkbXYd/62eZlyrm8SPWjVi0wVWLMS9xvK875BOPE0k1zmWMTUyXvgNS+0 kFig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:reply-to:subject:to:references :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=UIwJJl1ZATE7qNfFfo3v9+gj9qwA5PqC1tnbSWqS4JQ=; b=RTJEJMgV2yvClT/TUoCC/TAMNOOzcSgga6GRn/DPKDCvvTezjwllD7YzuFN6gbQZ7d YAXBTm/PuHwAe88AoDp+DZ19zxJl+eTOi2ayCSBFNayVmG+EM41X0Wi3gqoyyhK8vAO3 O8YfB3rIXh+CNIzRdbHK5cigek371Pq35U7DVKbRA2HAZbqUVO3FFw0Bu2TV4Z2WhE8p sz6AXuBaxR2vnGhsD13ehh71zXsHlkQ7//vf6uT6mNkjD/VtsLYXUq0INGkq/UtthJFu CojOv96WIgYWEmLD/oomCMo5VQ9vED0q5YtWXsKG5iMWHDDOUdNl+etB30c5fPPPQ/oZ UlEA== X-Gm-Message-State: AOAM5320ItnLvQNSaKwOWdU9hK3ZX59qxjYo2oFwRm2dZ8+LFYOQsSml VwWKQNaeLCOgViYeGth0bpSwkg5qQoU= X-Google-Smtp-Source: ABdhPJx5u0D8Z1WAy36YxKjkrnz4hvf6m0uggmZl4SgzxHbaSwS8n8DQjqbfHBT2n7kQ2UOS6meVBg== X-Received: by 2002:a1c:b4c4:: with SMTP id d187mr1711608wmf.38.1610536422296; Wed, 13 Jan 2021 03:13:42 -0800 (PST) Received: from [88.208.79.100] (halouny.humusoft.cz. [88.208.79.100]) by smtp.gmail.com with ESMTPSA id i11sm2402018wmd.47.2021.01.13.03.13.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Jan 2021 03:13:41 -0800 (PST) Sender: Michal Meloun From: Michal Meloun X-Google-Original-From: Michal Meloun Reply-To: mmel@freebsd.org Subject: Re: git: bafb68265672 - main - Fix for off-by-one in GPIO driver after r368585. While at it declare the iteration variable outside the for-loop to appease older compilers. To: Hans Petter Selasky , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202101130907.10D97J6M058131@gitrepo.freebsd.org> Message-ID: <1bbcc331-9a7a-f2d5-a71b-28e55ef32d40@freebsd.org> Date: Wed, 13 Jan 2021 12:13:43 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <202101130907.10D97J6M058131@gitrepo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4DG4ZK4pHCz4Vwd X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jan 2021 11:13:45 -0000 On 13.01.2021 10:07, Hans Petter Selasky wrote: > The branch main has been updated by hselasky: > > URL: https://cgit.FreeBSD.org/src/commit/?id=bafb682656724d06045fa494efb83a4312036f1f > > commit bafb682656724d06045fa494efb83a4312036f1f > Author: Hans Petter Selasky > AuthorDate: 2021-01-12 17:46:09 +0000 > Commit: Hans Petter Selasky > CommitDate: 2021-01-13 09:06:30 +0000 > > Fix for off-by-one in GPIO driver after r368585. > While at it declare the iteration variable outside the for-loop > to appease older compilers. Why? All supported compilers are familiar with this variable declaration. It is explicitly allowed by style (9) and makes the code much more readable, IMHO. Michal > Sponsored by: Mellanox Technologies // NVIDIA Networking > --- > sys/dev/gpio/gpioc.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/sys/dev/gpio/gpioc.c b/sys/dev/gpio/gpioc.c > index 727b07a70589..83d55742a3a2 100644 > --- a/sys/dev/gpio/gpioc.c > +++ b/sys/dev/gpio/gpioc.c > @@ -567,6 +567,7 @@ gpioc_probe(device_t dev) > static int > gpioc_attach(device_t dev) > { > + int i; > int err; > struct gpioc_softc *sc; > struct make_dev_args devargs; > @@ -582,7 +583,7 @@ gpioc_attach(device_t dev) > return (err); > sc->sc_pin_intr = malloc(sizeof(struct gpioc_pin_intr) * sc->sc_npins, > M_GPIOC, M_WAITOK | M_ZERO); > - for (int i = 0; i <= sc->sc_npins; i++) { > + for (i = 0; i < sc->sc_npins; i++) { > sc->sc_pin_intr[i].pin = malloc(sizeof(struct gpiobus_pin), > M_GPIOC, M_WAITOK | M_ZERO); > sc->sc_pin_intr[i].sc = sc; > @@ -612,11 +613,12 @@ gpioc_detach(device_t dev) > { > struct gpioc_softc *sc = device_get_softc(dev); > int err; > + int i; > > if (sc->sc_ctl_dev) > destroy_dev(sc->sc_ctl_dev); > > - for (int i = 0; i <= sc->sc_npins; i++) { > + for (i = 0; i < sc->sc_npins; i++) { > mtx_destroy(&sc->sc_pin_intr[i].mtx); > free(&sc->sc_pin_intr[i].pin, M_GPIOC); > } >