From owner-svn-src-all@freebsd.org Sun Oct 6 03:22:07 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2D384F9072 for ; Sun, 6 Oct 2019 03:22:07 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46m86l0W0qz4V0r for ; Sun, 6 Oct 2019 03:22:07 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id DEFDF10845 for ; Sun, 6 Oct 2019 03:22:06 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-qk1-f173.google.com with SMTP id 201so9521162qkd.13 for ; Sat, 05 Oct 2019 20:22:06 -0700 (PDT) X-Gm-Message-State: APjAAAX4zMjmqj+yTIZkKrYcEia1xJGP7f5cVnTmRbO5xBkMjrlR8667 py4SR7Xo97bCnQoBXMyTlOQVBgiGmeZIrUrwnr0= X-Received: by 2002:ae9:e88a:: with SMTP id a132mt15785202qkg.120.1570332126268; Sat, 05 Oct 2019 20:22:06 -0700 (PDT) MIME-Version: 1.0 References: <201910052152.x95Lq6IP021482@repo.freebsd.org> In-Reply-To: <201910052152.x95Lq6IP021482@repo.freebsd.org> From: Kyle Evans Date: Sat, 5 Oct 2019 22:21:55 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r353129 - in head/sys: kern sys Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Oct 2019 03:22:07 -0000 On Sat, Oct 5, 2019 at 4:52 PM Kyle Evans wrote: > > Author: kevans > Date: Sat Oct 5 21:52:06 2019 > New Revision: 353129 > URL: https://svnweb.freebsd.org/changeset/base/353129 > > Log: > Remove the remnants of SI_CHEAPCLONE > > SI_CHEAPCLONE was introduced in r66067 for use with cloned bpfs. It was > later also used in tty, tun, tap at points. The rough timeline for being > removed in each of these is as follows: > > - r181690: bpf switched to use cdevpriv API by ed@ > - r181905: ed@ rewrote the TTY later to be mpsafe > - r204464: kib@ removes it from tun/tap, declaring it unused > > I've not yet been able to dig up any other consumers in the intervening 9 > years. It is no longer set on any devices in the tree and leaves an > interesting situation in make_dev_sv where we're ok with the device already > being set SI_NAMED. > I guess a follow-up question to the list... do we consider SI_CHEAPCLONE imperative to keep around in stable/ branches? It hasn't been used in head for years, and I'd guess downstream projects don't intentionally use it either. I don't care enough to axe it, but I'd like to MFC my newdev() change since that was driven by some plans to use make_dev_s in if_tuntap... newdev will need a slight ~2 line addition in stable if SI_CHEAPCLONE sticks around. Thanks, Kyle Evans