Date: Wed, 22 Mar 2017 00:32:39 +0300 From: Slawa Olhovchenkov <slw@zxy.spb.ru> To: Gleb Smirnoff <glebius@FreeBSD.org> Cc: John Baldwin <jhb@freebsd.org>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r315662 - in head: contrib/bsnmp/snmp_mibII contrib/ipfilter/ipsend lib/libprocstat sys/netinet sys/sys usr.bin/netstat usr.bin/sockstat usr.bin/systat usr.sbin/tcpdrop usr.sbin/trpt Message-ID: <20170321213239.GX70430@zxy.spb.ru> In-Reply-To: <20170321204022.GX23308@FreeBSD.org> References: <201703210639.v2L6dnRf055522@repo.freebsd.org> <1782817.djIc6TfI1t@ralph.baldwin.cx> <20170321185004.GW23308@FreeBSD.org> <20170321195202.GF86500@zxy.spb.ru> <20170321204022.GX23308@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Mar 21, 2017 at 01:40:22PM -0700, Gleb Smirnoff wrote: > On Tue, Mar 21, 2017 at 10:52:02PM +0300, Slawa Olhovchenkov wrote: > S> > On Tue, Mar 21, 2017 at 10:40:34AM -0700, John Baldwin wrote: > S> > J> First, this is a very good change and long overdue in divorcing the > S> > J> user-facing structure for live system reporting vs the kernel structure. > S> > J> > S> > J> However, I realize you don't use info from netstat when debugging kernel > S> > J> crash dumps, but other people _do_. It's ok if the kvm bits of netstat > S> > J> require a matching kernel and thus require recompiling everytime the ABI > S> > J> changes, but it is useful to have them. Please restore those. > S> > > S> > I have very much anticipated this comment from you, John. > S> > > S> > I would like to remind you, that we have had this very exact conversation > S> > back when I removed kvm support from netstat/route.c. Let me search the > S> > archives: > S> > > S> > https://lists.freebsd.org/pipermail/svn-src-head/2015-April/070480.html > S> > > S> > This conversation has had a continuation on IRC, which I don't archive. > S> > > S> > AFAIR, first I told that with all my involvement into networking stack, > S> > I never ever had experienced a need to run route stats on a core. The > S> > debugger were the only useful tool. And that opinion was seconded by > S> > other network hackers. Then we discussed that a proper tool chould use > S> > dynamic type parsing and not kvm(3). You said that future gdb has python > S> > scripting and that would work fine. Meanwhile, you insisted that I restore > S> > the functionality. I resisted to put kvm(3) back into netstat/route.c, and > S> > instead I created a gdb script that prints exactly what 'nestat -anr -M core' > S> > prints. And I committed the script just to satisfy your demand: > S> > > S> > tools/debugscripts/netstat-anr.gdb > S> > > S> > Can you please fairly answer, have you (or anyone else) ever used the > S> > script during these 2 years? > S> > > S> > I believe, the inpcb/tcpcb printing from a core functionality has the > S> > same level of real usefulness. I could create the same script for pcbs, > S> > and I am afraid it is going to share fate of netstat-anr.gdb. > S> > S> How long run this script for core file w/ 40K TCP connections? > > You tell me. When I analyze cores, I don't read through 40K TCP connections. Real, frech core: # grep netstat /var/crash/core.txt.3 netstat -s netstat -m netstat: memstat_kvm_all: invalid address (0x0) netstat -anA netstat -aL # grep -c tcp4 /var/crash/core.txt.3 38172 This created automaticly at reboot and boot paused until core.txt created.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170321213239.GX70430>