From nobody Wed May 27 15:30:08 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gQYTX3XCCz6fC6q for ; Wed, 27 May 2026 15:30:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gQYTX1X1lz3Sxq for ; Wed, 27 May 2026 15:30:08 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779895808; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hjfDuZe2q84+/YUkcdxG98p4aVypiS3nzPVIZs3DMsM=; b=Oho5nXaOXCf+BbPzEH7vpx7sBb4lQXkc2035TtqPw4GrAe85ldpYb6xLS9py/agdPQpnp9 KyydS0BRIEXnhAYUP9qs90FcY9VyTNRp9akNvTLn3XIHmgK9Xd7vXTul0dqmHxZsu0YRNU S4HMXVyFLsVHaseKImxaG0Ju5m3/yQ0ZDAlags9nhzS8ea7wtbRTJu4nCmcm5eC9nPBUzB HSO7idEFGpaSi937W7mYLwTerPGYHvQKVW94CyKZINoSkUv0RW7WtX2zt5wkvQXfnnK9/v sG5f+A1BG0zT6H7kMqpx2zvzAKbQcutca+sm7Mrxo7tOnwYM+xzQqQ0O+AvUDw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1779895808; a=rsa-sha256; cv=none; b=Q5jm38Fo12qBqCEbz8orlWrFduLGadQSFV1mdAI2vgyZuVmItc9CxGecDnv7cYRTC7WOHO mYntgibZPYvyk3B0GmYyXth04t4iIgpSJZuW8cwnlFJvSXmi9cXygELLej3olRGSNRVgl8 GwSfUUWAiH7wHwufWaVxNcRvadDgXHrVOcjd/XmoAdkZi+CJ7bDWF4eHT2bo8j1gtAtsE5 wVGRYn/lVTC6fTEXCpCauhfBnIX3oV9Lyel2Ku1c8jPS7qgRM+xV0ArEKn3DcYytvxrEjd XsOe48nVWyUkdDLPp5wGKHsiokxIffDCmFzea/YNddnwOPerJEIvczKYfDCxpg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779895808; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hjfDuZe2q84+/YUkcdxG98p4aVypiS3nzPVIZs3DMsM=; b=WwmvqN0A/858IpvLWu2QmDDjDFPT/P0eI2O4utsTSiyMa2/LXf0sq4AUEyEz4nkjl+XcbT 0lpYEqN1ULT5r9cuTD+Cp0+fJYKGn6jI1urRTx0bviuc11w5AJILf6npyvKfpdmEXavXL0 InIkAGZLVPv4YruDfIiLptitwGSn+StXapteU0aXdtSQbBd9ljjhZ6OMKmCV88qwXsJ8Os 1oQ0YAzR7JfqXUPt2iSST8porMWgqPWqTtpuyfzXg/LwWzqo+1jNI8GwovtipiL2Iupc7P eizlrsUSAUqwUZlBTZlQ/sI7ejXQ95p+GobsTf5BOIObaucgisZQHqASfq0Isw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gQYTX14FSz14QD for ; Wed, 27 May 2026 15:30:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 27f29 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 27 May 2026 15:30:08 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Christos Margiolis Subject: git: 6f130b220d7c - main - sound: Remove dead EQ FEEDEQ_DISABLE code List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: christos X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 6f130b220d7ce64ce65f076a21edea034d14482b Auto-Submitted: auto-generated Date: Wed, 27 May 2026 15:30:08 +0000 Message-Id: <6a170e00.27f29.454c1d56@gitrepo.freebsd.org> The branch main has been updated by christos: URL: https://cgit.FreeBSD.org/src/commit/?id=6f130b220d7ce64ce65f076a21edea034d14482b commit 6f130b220d7ce64ce65f076a21edea034d14482b Author: Christos Margiolis AuthorDate: 2026-04-17 15:05:33 +0000 Commit: Christos Margiolis CommitDate: 2026-05-27 15:27:11 +0000 sound: Remove dead EQ FEEDEQ_DISABLE code If EQ is disabled, we never reach those code paths in the first place. Sponsored by: The FreeBSD Foundation MFC after: 1 week Pull Request: https://ron-dev.freebsd.org/FreeBSD/src/pulls/15 --- sys/dev/sound/pcm/feeder_eq.c | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/sys/dev/sound/pcm/feeder_eq.c b/sys/dev/sound/pcm/feeder_eq.c index 8f3acbf4e156..fe47a9d7e434 100644 --- a/sys/dev/sound/pcm/feeder_eq.c +++ b/sys/dev/sound/pcm/feeder_eq.c @@ -148,19 +148,6 @@ feed_eq_biquad(struct feed_eq_info *info, uint8_t *dst, uint32_t count, pmul = feed_eq_preamp[info->preamp].mul; pshift = feed_eq_preamp[info->preamp].shift; - if (info->state == FEEDEQ_DISABLE) { - j = count * info->channels; - dst += j * AFMT_BPS(fmt); - do { - dst -= AFMT_BPS(fmt); - v = pcm_sample_read(dst, fmt); - v = ((intpcm64_t)pmul * v) >> pshift; - pcm_sample_write(dst, v, fmt); - } while (--j != 0); - - return; - } - treble = &(info->coeff[info->treble.gain].treble); bass = &(info->coeff[info->bass.gain].bass); @@ -369,9 +356,6 @@ feed_eq_feed(struct pcm_feeder *f, struct pcm_channel *c, uint8_t *b, info = f->data; - if (info->state == FEEDEQ_DISABLE) - return (FEEDER_FEED(f->source, c, b, count, source)); - dst = b; count = SND_FXROUND(count, info->align);