From owner-svn-ports-head@FreeBSD.ORG Sun Apr 21 14:58:18 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 5CB369F5; Sun, 21 Apr 2013 14:58:18 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-ia0-x22f.google.com (mail-ia0-x22f.google.com [IPv6:2607:f8b0:4001:c02::22f]) by mx1.freebsd.org (Postfix) with ESMTP id E7F6E15EF; Sun, 21 Apr 2013 14:58:17 +0000 (UTC) Received: by mail-ia0-f175.google.com with SMTP id i38so505493iae.6 for ; Sun, 21 Apr 2013 07:58:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=L/Mjj9ia/Zlc5R3PFZyuHzRm6ykO0PeBJ+5N1w8rb/Q=; b=QYyVKkBoyDW8RGmsfPLdG6PWXHSCH8K06nciCGdlOkvYXzICzU5LTxDg+tIG6PiC2h pR2L+W2JkENjhB+ikf4Vsh3rsxxmpLZaklb1wGfVySPuNDtn78pJkAZ1Hlcq3RZAXyOI L6lTFmCAkMER+sRT5RVp3SW/D56TMn1/V4+l8O0tU9dJE7f09qr2jaqC4Luzl742jcDj 3XjttzFiuIy1BrrCKLkdCYqJjUHtjGms+VS4E5WXblh3DXxzwTdB/EzZU5vaAMnPF6dx 7bfqsYb6+H22+g67Jdn9GgDvIjuz0kr9GQcTclYXANyrti6gdtosElLr7k6pNlNfzONq h6+Q== MIME-Version: 1.0 X-Received: by 10.50.128.16 with SMTP id nk16mr6319363igb.15.1366556297628; Sun, 21 Apr 2013 07:58:17 -0700 (PDT) Received: by 10.64.58.52 with HTTP; Sun, 21 Apr 2013 07:58:17 -0700 (PDT) Received: by 10.64.58.52 with HTTP; Sun, 21 Apr 2013 07:58:17 -0700 (PDT) In-Reply-To: <20130421144521.GA61094@FreeBSD.org> References: <201304191335.r3JDZF4B031649@svn.freebsd.org> <20130419134935.GA29457@FreeBSD.org> <20130419150333.M65185@FreeBSD.org> <20130420051737.GA23612@FreeBSD.org> <20130420133158.M15119@martymac.org> <20130421144521.GA61094@FreeBSD.org> Date: Sun, 21 Apr 2013 15:58:17 +0100 Message-ID: Subject: Re: svn commit: r316102 - in head/emulators/dolphin-emu-devel: . files From: Chris Rees To: Alexey Dokuchaev , Mark Linimon Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: svn-ports-head@freebsd.org, Eitan Adler , svn-ports-all@freebsd.org, ports-committers@freebsd.org, Ganael LAPLANCHE , Ganael LAPLANCHE X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Apr 2013 14:58:18 -0000 On 21 Apr 2013 15:45, "Alexey Dokuchaev" wrote: > > On Sat, Apr 20, 2013 at 01:48:52PM +0000, Ganael LAPLANCHE wrote: > > Then, I see three possibilities : > > > > 1) Fix the BROKEN message with something more incentive, like just : > > > > .if ${ARCH} == "powerpc" > > BROKEN= Not tested on powerpc > > .endif > > Bad idea. If port breaks during the build (that's when we mark it as > BROKEN), just state the reason (try to be concise yet precise), and maybe > quote relevant part of the build log in commit message (just a few lines > would suffice). > > BROKEN has nothing to do with the fact if software in question was tested > or not, whatever "tested" might mean. > > > but I don't find this solution very clean as, after all, I have not > > tested other tier-2 architectures, so why just put a message for powerpc ? > > Nor is it relevant if was was tested on any tier-X arch. BROKEN is used > when something does not build (or, more strictly, does not build on the > cluster). > > > 2) I could rewrite it this way : > > > > .if ${ARCH} != "i386" && ${ARCH} != "amd64" > > BROKEN= Only tested on i386 and amd64 > > .endif > > Just as bad, for the same reasons. > > > 3) As I don't know exactly why this BROKEN message has been introduced > > and whether the port now builds or not on powerpc and other tier-2 archs > > (I don't have hardware to test it), > > Unfortunately, not just you, most of us have no access to tier-2 hardware. > However, we need to generate packages for those releases, so naturally, we > have such boxes in the build cluster, and portmgr@ guys will occasionally > mark some ports as BROKEN on them. Sadly, most of the time we cannot do > anything about it (except for few trivial cases of when pluto/flame is > enough to reproduce the error). > > I would probably try to locate the recent powerpc build log, see why it > fails, and provide better BROKEN message. If the port builds fine now > (there is a slight chance), just remove it for good's sake. ;-) Mark may correct me here, but I seem to remember that if there's a chance of the change fixing it you should just remove the tag, and a portmgr will readd if necessary. By the way, you should not quote strings in Makefiles. Chris