From owner-svn-src-head@freebsd.org Thu Nov 5 19:17:00 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E1E87A269EB; Thu, 5 Nov 2015 19:17:00 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id BAB30164C; Thu, 5 Nov 2015 19:17:00 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id D39CDB9BA; Thu, 5 Nov 2015 14:16:59 -0500 (EST) From: John Baldwin To: Oleksandr Tymoshenko Cc: Andrew Turner , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r290245 - in head/sys/contrib/vchiq/interface: vchi vchiq_arm Date: Thu, 05 Nov 2015 10:49:24 -0800 Message-ID: <4544430.IVoCLBVNIY@ralph.baldwin.cx> User-Agent: KMail/4.14.3 (FreeBSD/10.2-STABLE; KDE/4.14.3; amd64; ; ) In-Reply-To: References: <201511012217.tA1MHdMJ047219@repo.freebsd.org> <20151102093603.0aebe7a8@bender.Home> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Thu, 05 Nov 2015 14:16:59 -0500 (EST) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Nov 2015 19:17:01 -0000 On Monday, November 02, 2015 11:37:38 AM Oleksandr Tymoshenko wrote: > > > On Nov 2, 2015, at 1:36 AM, Andrew Turner wrote: > > > > On Sun, 1 Nov 2015 22:17:39 +0000 (UTC) > > Oleksandr Tymoshenko wrote: > > > >> Author: gonzo > >> Date: Sun Nov 1 22:17:39 2015 > >> New Revision: 290245 > >> URL: https://svnweb.freebsd.org/changeset/base/290245 > >> > >> Log: > >> Synchronize with latest upstream VCHI code: > >> > >> - Add LIB_VERSION ioctl > >> - Add CLOSE_DELIVERED ioctl > >> - Bump code version > >> > >> Upstream version: 3782f2ad42c08f4d32f64138f8be7341afc380f5 > > > > Was there a reason we don't use the vendor-sys area for vchiq? > > What Adrian said: original code is not very portable and I have to go through manual merge in my staging repo and only then merge to sys/ area One benefit of keeping a corresponding area in vendor-sys in sync is it makes it easier for other folks to pick this up in the future if need be. Noting the upstream version in each update is probably equivalent in functionality, though it is not how we do it in the rest of the tree. Also, Adrian, most of us do a lot of this work (FreeBSD) as volunteers. Even if some of us work on some of it for ${WORK} we work on other bits in our spare time for $0 as well, so that's a lame cop out. Part of the reason we do this in our spare time is because it's a chance to do things "right", not just quick hacks to satisfy a business-deadline at ${WORK} (to paraphrase gibbs@). -- John Baldwin