Date: Tue, 26 Jun 2012 14:45:42 GMT From: Luca Pizzamiglio <luca.pizzamiglio@gmail.com> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/169448: [MAINTAINER] Fix THREADS support on devel/gdb Message-ID: <201206261445.q5QEjg03042151@red.freebsd.org> Resent-Message-ID: <201206261450.q5QEo3qf045813@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 169448
>Category: ports
>Synopsis: [MAINTAINER] Fix THREADS support on devel/gdb
>Confidential: no
>Severity: serious
>Priority: high
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: maintainer-update
>Submitter-Id: current-users
>Arrival-Date: Tue Jun 26 14:50:02 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator: Luca Pizzamiglio
>Release: FreeBSD 8.3-STABLE
>Organization:
>Environment:
>Description:
THREADS support was wrong managed by the Makefile. That caused the support missing.
A couple of syntax typo are also fixed in the gdb link management.
Thanks to Andriy Gapon and Kurt Jaeger for the support!
>How-To-Repeat:
>Fix:
Fixed on the patch.
Patch attached with submission follows:
diff -Nru devel/gdb.orig/Makefile devel/gdb/Makefile
--- devel/gdb.orig/Makefile 2012-06-26 14:21:41.000000000 +0200
+++ devel/gdb/Makefile 2012-06-26 16:39:04.000000000 +0200
@@ -3,12 +3,12 @@
# Date created: 16 November 2010
# Whom: Steven Kreuzer <skreuzer@FreeBSD.org>
#
-# $FreeBSD: ports/devel/gdb/Makefile,v 1.18 2012/06/23 09:12:05 scheidell Exp $
+# $FreeBSD$
#
PORTNAME= gdb
PORTVERSION= 7.4.1
-PORTREVISION= 1
+PORTREVISION= 2
CATEGORIES= devel
MASTER_SITES= ${MASTER_SITE_GNU:S,$,:gdb,}
MASTER_SITE_SUBDIR=gdb/:gdb
@@ -52,7 +52,7 @@
.include <bsd.port.options.mk>
-.if ${PORT_OPTIONS:MGDB_LINK)
+.if ${PORT_OPTIONS:MGDB_LINK}
PLIST_SUB+= GDB_LINK=""
.else
PLIST_SUB+= GDB_LINK="@comment "
@@ -90,7 +90,7 @@
post-patch:
@${REINPLACE_CMD} -e 's/$$/ [GDB v${PORTVERSION} for FreeBSD]/' \
${WRKSRC}/gdb/version.in
-.if empty(PORT_OPTIONS:MTHREADS)
+.if ${PORT_OPTIONS:MTHREADS}
@${CP} ${FILESDIR}/fbsd-threads.c ${WRKSRC}/gdb/
.endif
@${CP} ${FILESDIR}/amd64bsd-nat.h ${WRKSRC}/gdb
@@ -99,11 +99,9 @@
${INSTALL_PROGRAM} ${WRKSRC}/gdb/gdb ${PREFIX}/bin/gdb${VER}
${LN} ${PREFIX}/bin/gdb${VER} ${PREFIX}/bin/gdbtui${VER}
${INSTALL_MAN} ${WRKSRC}/gdb/gdb.1 ${MAN1PREFIX}/man/man1/gdb${VER}.1
-#.if defined(WITH_GDB_LINK)
-.if ${PORT_OPTIONS:MGDB_LINK)
+.if ${PORT_OPTIONS:MGDB_LINK}
${LN} -sf gdb${VER} ${PREFIX}/bin/gdb
.endif
-#.if defined(WITH_PYTHON)
.if ${PORT_OPTIONS:MPYTHON}
(cd ${WRKSRC}/gdb; ${GMAKE} install-python )
(cd ${WRKSRC}/gdb/data-directory; ${GMAKE} install-python )
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201206261445.q5QEjg03042151>