From owner-freebsd-current@FreeBSD.ORG  Thu Aug 18 21:18:32 2005
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: current@freebsd.org
Delivered-To: freebsd-current@FreeBSD.ORG
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id CFDD316A41F
	for <current@freebsd.org>; Thu, 18 Aug 2005 21:18:32 +0000 (GMT)
	(envelope-from oz@nixil.net)
Received: from nixil.net (nixil.net [161.58.222.1])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 6D7EF43D46
	for <current@freebsd.org>; Thu, 18 Aug 2005 21:18:32 +0000 (GMT)
	(envelope-from oz@nixil.net)
Received: from [10.20.12.64] (fw.oremut02.us.wh.verio.net [198.65.168.24])
	(authenticated bits=0)
	by nixil.net (8.13.1/8.13.1) with ESMTP id j7ILICTK065628
	(version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NOT);
	Thu, 18 Aug 2005 15:18:17 -0600 (MDT)
Message-ID: <4304FAAE.4090109@nixil.net>
Date: Thu, 18 Aug 2005 15:16:30 -0600
From: Phil Oleson <oz@nixil.net>
User-Agent: Mozilla Thunderbird 1.0.5 (X11/20050714)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Stefan Farfeleder <stefan@fafoe.narf.at>
References: <20050818165050.58B835D07@ptavv.es.net>
	<4304DAE0.1040702@nixil.net>
	<20050818205921.GR21905@wombat.fafoe.narf.at>
In-Reply-To: <20050818205921.GR21905@wombat.fafoe.narf.at>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeded SMTP AUTH authentication, not delayed by
	milter-greylist-1.6 (nixil.net [161.58.222.1]);
	Thu, 18 Aug 2005 15:18:18 -0600 (MDT)
X-Virus-Scanned: ClamAV 0.86.1/1034/Thu Aug 18 14:07:58 2005 on nixil.net
X-Virus-Status: Clean
Cc: current@freebsd.org
Subject: Re: Unable to build libedit
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Aug 2005 21:18:32 -0000

Stefan Farfeleder wrote:
> On Thu, Aug 18, 2005 at 01:00:48PM -0600, Phil Oleson wrote:
> 
>>Personally, I'm still unsure why we have histedit.h pre-installed in
>>src/include.  This might be showing my ignorance of some of the build
>>mechanisms in the main src tree, but wouldn't this work out better if
>>histedit.h was located in src/lib/libedit until install time?
> 
> 
> I guess the reason for putting most headers into src/include is that it
> prevents dozens of -I paths while building.
> 
> Stefan

well, I was looking at the Makefile in src/lib/libedit and it only uses
'CFLAGS+= -I. -I${.CURDIR}',  So in the upgrade case it wouldn't find
the histedit.h in /usr/obj/usr/src/tmp/usr/include.  Though now that I
think about it, I can see where the -I paths for other base system apps
that use libedit would suffer (sh,tftp,fsdb,cdcontrol,lpr-lpc).  I think
an additional -I needs to be added to the libedit Makefile, something
like -I${WORLDTMP}/usr/include ??

	Phil.