Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 22 Dec 2015 14:50:02 +0100
From:      Kristof Provost <kp@FreeBSD.org>
To:        "Jonathan T. Looney" <jtl@FreeBSD.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r292599 - head/sys/netinet
Message-ID:  <3AB254FD-68BF-4395-8BAA-A0B5D51F1049@FreeBSD.org>
In-Reply-To: <201512221341.tBMDfp04019336@repo.freebsd.org>
References:  <201512221341.tBMDfp04019336@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Thanks!

Kristof

> On 22 Dec 2015, at 14:41, Jonathan T. Looney <jtl@FreeBSD.org> wrote:
>=20
> Author: jtl
> Date: Tue Dec 22 13:41:50 2015
> New Revision: 292599
> URL: https://svnweb.freebsd.org/changeset/base/292599
>=20
> Log:
>  Fix a panic when launching VNETs after the commit of r292309.
>=20
>  Differential Revision:	https://reviews.freebsd.org/D4645
>  Reviewed by:	rrs
>  Reported by:	kp
>  Tested by:	kp
>  Sponsored by:	Juniper Networks
>=20
> Modified:
>  head/sys/netinet/tcp_subr.c
>=20
> Modified: head/sys/netinet/tcp_subr.c
> =
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
> --- head/sys/netinet/tcp_subr.c	Tue Dec 22 13:19:29 2015	=
(r292598)
> +++ head/sys/netinet/tcp_subr.c	Tue Dec 22 13:41:50 2015	=
(r292599)
> @@ -593,10 +593,6 @@ tcp_init(void)
> 	if (hhook_head_register(HHOOK_TYPE_TCP, HHOOK_TCP_EST_OUT,
> 	    &V_tcp_hhh[HHOOK_TCP_EST_OUT], =
HHOOK_NOWAIT|HHOOK_HEADISINVNET) !=3D 0)
> 		printf("%s: WARNING: unable to register helper hook\n", =
__func__);
> -	/* Setup the tcp function block list */
> -	TAILQ_INIT(&t_functions);
> -	rw_init_flags(&tcp_function_lock, "tcp_func_lock" , 0);
> -	register_tcp_functions(&tcp_def_funcblk, M_WAITOK);
> 	hashsize =3D TCBHASHSIZE;
> 	TUNABLE_INT_FETCH(tcbhash_tuneable, &hashsize);
> 	if (hashsize =3D=3D 0) {
> @@ -675,6 +671,10 @@ tcp_init(void)
> 	tcp_rexmit_slop =3D TCPTV_CPU_VAR;
> 	tcp_finwait2_timeout =3D TCPTV_FINWAIT2_TIMEOUT;
> 	tcp_tcbhashsize =3D hashsize;
> +	/* Setup the tcp function block list */
> +	TAILQ_INIT(&t_functions);
> +	rw_init_flags(&tcp_function_lock, "tcp_func_lock" , 0);
> +	register_tcp_functions(&tcp_def_funcblk, M_WAITOK);
>=20
> 	if (tcp_soreceive_stream) {
> #ifdef INET
>=20




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3AB254FD-68BF-4395-8BAA-A0B5D51F1049>