From owner-freebsd-x11@FreeBSD.ORG Sat Apr 14 19:40:29 2007 Return-Path: X-Original-To: x11@FreeBSD.org Delivered-To: freebsd-x11@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id BCD5716A404; Sat, 14 Apr 2007 19:40:29 +0000 (UTC) (envelope-from kris@obsecurity.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id AEAF913C4AD; Sat, 14 Apr 2007 19:40:29 +0000 (UTC) (envelope-from kris@obsecurity.org) Received: from obsecurity.dyndns.org (elvis.mu.org [192.203.228.196]) by elvis.mu.org (Postfix) with ESMTP id 782101A3C1C; Sat, 14 Apr 2007 12:40:40 -0700 (PDT) Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id AB677512F0; Sat, 14 Apr 2007 15:40:28 -0400 (EDT) Date: Sat, 14 Apr 2007 15:40:28 -0400 From: Kris Kennaway To: lesi@FreeBSD.org, x11@FreeBSD.org Message-ID: <20070414194028.GB2313@xor.obsecurity.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="oLBj+sq0vYjzfsbl" Content-Disposition: inline User-Agent: Mutt/1.4.2.2i Cc: Subject: Upgrade script X-BeenThere: freebsd-x11@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: X11 on FreeBSD -- maintaining and support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Apr 2007 19:40:29 -0000 --oLBj+sq0vYjzfsbl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline The script is basically OK, but it needs some more error checking: * It should bail if the backup tarball fails (e.g. disk full) * Before spamming /usr/local there needs to be a check that no files will be skipped (since you are using tar -k to avoid overwriting existing files). Probably something using find -type f -o -type l and then comm(1) would be appropriate; the user should be warned about these conflicts and either bail out until they resolve them, or just proceed and let them deal with them by hand from the backup tarball. * There is also the possibility for directories to change permissions/ownership when they are spammed by tar. This is probably not important though. Thanks, Kris --oLBj+sq0vYjzfsbl Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) iD8DBQFGIS4sWry0BWjoQKURAo9JAKDkSpsxu9xNaMlY9+3z9Am5rxg+OwCdHsmb 1fjjYxvRPEs0aw7VZ6YpJa0= =rMCt -----END PGP SIGNATURE----- --oLBj+sq0vYjzfsbl--