Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 14 Jun 2019 19:09:07 +0000
From:      bugzilla-noreply@freebsd.org
To:        chromium@FreeBSD.org
Subject:   [Bug 238563] www/chromium: build failure
Message-ID:  <bug-238563-28929-wgrUFFi4mL@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-238563-28929@https.bugs.freebsd.org/bugzilla/>
References:  <bug-238563-28929@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D238563

--- Comment #4 from Carlos J. Puga Medina <cpm@freebsd.org> ---
(In reply to Konstantin Belousov from comment #3)

pthread_get_name_np is supported on 11.2-STABLE.

It's added in base/sampling_heap_profiler/sampling_heap_profiler.cc

--- base/sampling_heap_profiler/sampling_heap_profiler.cc.orig  2019-06-04
18:55:15 UTC
+++ base/sampling_heap_profiler/sampling_heap_profiler.cc
@@ -30,6 +30,10 @@
 #include <sys/prctl.h>
 #endif

+#if defined(OS_BSD)
+#include <pthread_np.h>
+#endif
+
 #if defined(OS_ANDROID) && BUILDFLAG(CAN_UNWIND_WITH_CFI_TABLE) && \
     defined(OFFICIAL_BUILD)
 #include "base/trace_event/cfi_backtrace_android.h"
@@ -65,6 +69,10 @@ const char* GetAndLeakThreadName() {
 #elif defined(OS_MACOSX)
   int err =3D pthread_getname_np(pthread_self(), name, kBufferLen);
   if (err =3D=3D 0 && *name !=3D '\0')
+    return strdup(name);
+#elif defined(OS_BSD)
+  pthread_get_name_np(pthread_self(), name, kBufferLen);
+  if (*name !=3D '\0')
     return strdup(name);
 #endif  // defined(OS_LINUX) || defined(OS_ANDROID)

We're working to unbreak chromium on 11.2-RELEASE.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-238563-28929-wgrUFFi4mL>