From owner-p4-projects@FreeBSD.ORG  Fri Mar 24 06:46:08 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 6F37516A420; Fri, 24 Mar 2006 06:46:08 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 4F7D116A400
	for <perforce@freebsd.org>; Fri, 24 Mar 2006 06:46:08 +0000 (UTC)
	(envelope-from imp@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 1E7CB43D45
	for <perforce@freebsd.org>; Fri, 24 Mar 2006 06:46:08 +0000 (GMT)
	(envelope-from imp@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id k2O6k8DW058381
	for <perforce@freebsd.org>; Fri, 24 Mar 2006 06:46:08 GMT
	(envelope-from imp@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.1/8.13.1/Submit) id k2O6k72O058378
	for perforce@freebsd.org; Fri, 24 Mar 2006 06:46:07 GMT
	(envelope-from imp@freebsd.org)
Date: Fri, 24 Mar 2006 06:46:07 GMT
Message-Id: <200603240646.k2O6k72O058378@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	imp@freebsd.org using -f
From: Warner Losh <imp@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 93919 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 24 Mar 2006 06:46:08 -0000

http://perforce.freebsd.org/chv.cgi?CH=93919

Change 93919 by imp@imp_Speedy on 2006/03/24 06:45:21

	report errors in some 'can't happen' cases to make sure
	that they are noticed.

Affected files ...

.. //depot/projects/arm/src/sys/arm/at91/at91.c#14 edit

Differences ...

==== //depot/projects/arm/src/sys/arm/at91/at91.c#14 (text+ko) ====

@@ -201,11 +201,14 @@
 	struct at91_ivar *ivar;
 
 	kid = device_add_child_ordered(dev, prio, name, unit);
-	if (kid == NULL)
-		return;
+	if (kid == NULL) {
+	    printf("Can't add child %s%d ordered\n", name, unit);
+	    return;
+	}
 	ivar = malloc(sizeof(*ivar), M_DEVBUF, M_WAITOK | M_ZERO);
 	if (ivar == NULL) {
 		device_delete_child(dev, kid);
+		printf("Can't add alloc ivar\n");
 		return;
 	}
 	device_set_ivars(kid, ivar);