From owner-svn-ports-head@FreeBSD.ORG Mon Mar 23 14:33:16 2015 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C7CC8FB3; Mon, 23 Mar 2015 14:33:16 +0000 (UTC) Received: from mail-we0-x232.google.com (mail-we0-x232.google.com [IPv6:2a00:1450:400c:c03::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6EBCD65A; Mon, 23 Mar 2015 14:33:16 +0000 (UTC) Received: by wegp1 with SMTP id p1so139372597weg.1; Mon, 23 Mar 2015 07:33:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=BsnNhKwfz+5dtMDBgWdq95FfBLKHuK65hhgdS7g4g1w=; b=CLNsvsPOeEdkSlqEQSotq2HPwQVhpwNGFEu0VnxjpP2ZGZPiQ3iwlXN3mQzW0JQOck bAGy4Hrnf8sDG1G9thoyui0uVHXmSh+FQ7WzlvV1GU1gyxNX59MId35yz+ECI010CGrr tWOO4xeRAJ5hKtZoQZ7RSjdFWGqv9OHrBI/ftPwvGljvFX7CQ//tXFEpCSmrtYgB4VB7 EhO0GcR4sUvEcQWY7nZ8Yerg9LiP2rgJjGmIe/CfdmJPIBKoiS9fHhZ+HDNw0iqXVnML XRLap7jTH+jcWyJ+tvCgAaVRBfJE2dpimeyvasJJhynOwnLWCqe6ngusoHd5zMSdYV+o Cy5g== X-Received: by 10.194.94.1 with SMTP id cy1mr181787372wjb.127.1427121194842; Mon, 23 Mar 2015 07:33:14 -0700 (PDT) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by mx.google.com with ESMTPSA id hl15sm11497647wib.3.2015.03.23.07.33.13 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Mar 2015 07:33:14 -0700 (PDT) Sender: Baptiste Daroussin Date: Mon, 23 Mar 2015 15:33:12 +0100 From: Baptiste Daroussin To: Bryan Drewery Subject: Re: svn commit: r381955 - head/graphics/gdal Message-ID: <20150323143311.GC27378@ivaldir.etoilebsd.net> References: <201503222011.t2MKBHq7091087@svn.freebsd.org> <20150323015759.GA34402@FreeBSD.org> <550F8505.8010600@FreeBSD.org> <20150323135711.GB27378@ivaldir.etoilebsd.net> <5510220D.3030505@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="1SQmhf2mF2YjsYvc" Content-Disposition: inline In-Reply-To: <5510220D.3030505@FreeBSD.org> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: Sunpoet Po-Chuan Hsieh , svn-ports-head@freebsd.org, Alexey Dokuchaev , svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Mar 2015 14:33:17 -0000 --1SQmhf2mF2YjsYvc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 23, 2015 at 09:24:13AM -0500, Bryan Drewery wrote: > On 3/23/2015 8:57 AM, Baptiste Daroussin wrote: > > On Sun, Mar 22, 2015 at 10:14:13PM -0500, Bryan Drewery wrote: > >> On 3/22/2015 8:58 PM, Alexey Dokuchaev wrote: > >>> On Sun, Mar 22, 2015 at 08:11:17PM +0000, Sunpoet Po-Chuan Hsieh wrot= e: > >>>> New Revision: 381955 > >>>> URL: https://svnweb.freebsd.org/changeset/ports/381955 > >>>> QAT: https://qat.redports.org/buildarchive/r381955/ > >>>> > >>>> Log: > >>>> - Use -lpthread instead of -pthread > >>> > >>> Is -pthread going away anytime soon? I'm a bit worried of more alike > >>> changing one to another; since they're identical right now on FreeBSD, > >>> I'd rather reduce amount of patching, leaving whatever is picked by > >>> upstream, unless -lpthread really should be preferred over -pthread > >>> for some reason I'm unaware of (and ready to learn about). > >>> > >>> ./danfe > >>> > >> > >> It's a pointless change. Tijl explains here > >> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D198116#c4 > >> > >=20 > > This is not pointless at all this is a long standing thing that should = be > > cleaned out for a while, portmgr already gave long ago some blanket to = some > > developers to remove that along with all usage of PTHREAD_LIBS. The rea= son is > > that it is confusing for maintainers, as if they take example on some o= f our > > existing ports they might be driven in the wrong direction. > >=20 > > Working in cleaning up those is imho important > >=20 > > Regards, > > Bapt > >=20 >=20 > Reading the responses from David and Tijl I'm still at a loss at how > this is useful. From my understanding, and what David said, -pthread is > more portable. Reading documentation available from simple searching > leads me, as a naive developer, to use -pthread. Especially when looking > for Linux documentation. Using either is the same as the other on > FreeBSD as well. So why the major change? >=20 > Removing PTHREAD_LIBS makes sense since it is a needless variable > leftover from a more complicated past. But why change -pthread to > -lpthread? Why not -lthr since -lpthread is actually an alias to that? The goal is not to change anything but remove our gratuicious changes and patches. Meaning I am not ok with s/pthread/lpthread/ but I'm ok with removing all PTHREAD_LIBS macros in ports and all patches we do use to replace lpthread = with something else Bapt --1SQmhf2mF2YjsYvc Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlUQJCcACgkQ8kTtMUmk6Ey7sgCfUUovBz5Dih0o/+4CurC+eBos PS0Anjj/sf3hm4f3SfxgQs0DkumzKLZw =lpyh -----END PGP SIGNATURE----- --1SQmhf2mF2YjsYvc--