Date: Mon, 23 Mar 2015 15:33:12 +0100 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Bryan Drewery <bdrewery@FreeBSD.org> Cc: Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org>, svn-ports-head@freebsd.org, Alexey Dokuchaev <danfe@FreeBSD.org>, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r381955 - head/graphics/gdal Message-ID: <20150323143311.GC27378@ivaldir.etoilebsd.net> In-Reply-To: <5510220D.3030505@FreeBSD.org> References: <201503222011.t2MKBHq7091087@svn.freebsd.org> <20150323015759.GA34402@FreeBSD.org> <550F8505.8010600@FreeBSD.org> <20150323135711.GB27378@ivaldir.etoilebsd.net> <5510220D.3030505@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--1SQmhf2mF2YjsYvc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 23, 2015 at 09:24:13AM -0500, Bryan Drewery wrote: > On 3/23/2015 8:57 AM, Baptiste Daroussin wrote: > > On Sun, Mar 22, 2015 at 10:14:13PM -0500, Bryan Drewery wrote: > >> On 3/22/2015 8:58 PM, Alexey Dokuchaev wrote: > >>> On Sun, Mar 22, 2015 at 08:11:17PM +0000, Sunpoet Po-Chuan Hsieh wrot= e: > >>>> New Revision: 381955 > >>>> URL: https://svnweb.freebsd.org/changeset/ports/381955 > >>>> QAT: https://qat.redports.org/buildarchive/r381955/ > >>>> > >>>> Log: > >>>> - Use -lpthread instead of -pthread > >>> > >>> Is -pthread going away anytime soon? I'm a bit worried of more alike > >>> changing one to another; since they're identical right now on FreeBSD, > >>> I'd rather reduce amount of patching, leaving whatever is picked by > >>> upstream, unless -lpthread really should be preferred over -pthread > >>> for some reason I'm unaware of (and ready to learn about). > >>> > >>> ./danfe > >>> > >> > >> It's a pointless change. Tijl explains here > >> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D198116#c4 > >> > >=20 > > This is not pointless at all this is a long standing thing that should = be > > cleaned out for a while, portmgr already gave long ago some blanket to = some > > developers to remove that along with all usage of PTHREAD_LIBS. The rea= son is > > that it is confusing for maintainers, as if they take example on some o= f our > > existing ports they might be driven in the wrong direction. > >=20 > > Working in cleaning up those is imho important > >=20 > > Regards, > > Bapt > >=20 >=20 > Reading the responses from David and Tijl I'm still at a loss at how > this is useful. From my understanding, and what David said, -pthread is > more portable. Reading documentation available from simple searching > leads me, as a naive developer, to use -pthread. Especially when looking > for Linux documentation. Using either is the same as the other on > FreeBSD as well. So why the major change? >=20 > Removing PTHREAD_LIBS makes sense since it is a needless variable > leftover from a more complicated past. But why change -pthread to > -lpthread? Why not -lthr since -lpthread is actually an alias to that? The goal is not to change anything but remove our gratuicious changes and patches. Meaning I am not ok with s/pthread/lpthread/ but I'm ok with removing all PTHREAD_LIBS macros in ports and all patches we do use to replace lpthread = with something else Bapt --1SQmhf2mF2YjsYvc Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlUQJCcACgkQ8kTtMUmk6Ey7sgCfUUovBz5Dih0o/+4CurC+eBos PS0Anjj/sf3hm4f3SfxgQs0DkumzKLZw =lpyh -----END PGP SIGNATURE----- --1SQmhf2mF2YjsYvc--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150323143311.GC27378>