From owner-freebsd-current@FreeBSD.ORG Fri Jan 16 00:10:44 2009 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1A9191065697 for ; Fri, 16 Jan 2009 00:10:44 +0000 (UTC) (envelope-from dimitry@andric.com) Received: from tensor.andric.com (cl-327.ede-01.nl.sixxs.net [IPv6:2001:7b8:2ff:146::2]) by mx1.freebsd.org (Postfix) with ESMTP id C541F8FC17 for ; Fri, 16 Jan 2009 00:10:43 +0000 (UTC) (envelope-from dimitry@andric.com) Received: from [IPv6:2001:7b8:3a7:0:9495:274b:b36c:ce34] (unknown [IPv6:2001:7b8:3a7:0:9495:274b:b36c:ce34]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id D44DB11F838; Fri, 16 Jan 2009 01:10:42 +0100 (CET) Message-ID: <496FD082.6030509@andric.com> Date: Fri, 16 Jan 2009 01:10:42 +0100 From: Dimitry Andric User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9.1b3pre) Gecko/20090108 Shredder/3.0b2pre MIME-Version: 1.0 To: Marcel Moolenaar References: <496D0364.2060505@psg.com> <47d0403c0901131335h46e7b151p3768de9a3e2c2027@mail.gmail.com> <085BEE07-BAE5-4A45-A14D-9587987FAA5C@mac.com> <496F44FA.1070004@andric.com> <48C1C477-B7BE-43B0-AC57-9DEB7BF9AA88@mac.com> <496F7347.4060007@andric.com> <496F8D8A.1060508@andric.com> <496F928F.6010807@andric.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Randy Bush , Luiz Otavio O Souza , George Neville-Neil , Ben Kaduk , current@freebsd.org Subject: Re: GEOM and moving to CURRENT from 7.1 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Jan 2009 00:10:45 -0000 On 2009-01-15 20:55, Marcel Moolenaar wrote: > Thanks *very* much for testing! It's important that we > get the details right, so that we can consider adding > code to help in the migration and fix whatever is broken. In sysinstall, a standard installation writes the disks like so: usr.sbin/sysinstall/install.c: installStandard() usr.sbin/sysinstall/install.c: installCommit() usr.sbin/sysinstall/install.c: installInitial() usr.sbin/sysinstall/label.c: diskLabelCommit() usr.sbin/sysinstall/disks.c: diskPartitionWrite() lib/libdisk/write_i386_disk.c: Write_Disk() It looks like Write_Disk() always writes a partition table: int Write_Disk(const struct disk *d1) { [...] struct dos_partition *dp,work[NDOSPART]; [...] for (c1 = d1->chunks->part; c1; c1 = c1->next) { [... fills dp here ...] } [...] memcpy(mbrblk + DOSPARTOFF, dp, sizeof *dp * NDOSPART); mbrblk[512-2] = 0x55; mbrblk[512-1] = 0xaa; write_block(fd, 0, mbrblk, d1->sector_size); [...]