From owner-svn-src-stable-11@freebsd.org Mon Apr 2 16:13:49 2018 Return-Path: Delivered-To: svn-src-stable-11@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 83851F74E1A; Mon, 2 Apr 2018 16:13:49 +0000 (UTC) (envelope-from byond.lenox@gmail.com) Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 01BB285926; Mon, 2 Apr 2018 16:13:48 +0000 (UTC) (envelope-from byond.lenox@gmail.com) Received: by mail-wm0-f45.google.com with SMTP id t67so6760877wmt.0; Mon, 02 Apr 2018 09:13:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=FgkGMqDrQXhoBZmKwXpEx7Zc99nVi/+dnSvXHoTxHAY=; b=BRSYwqZNzoZwbvvwnuTQSyuTBWTrr1WmQ4Vu5b/tb0YNdgoByBy94ois6s1iMoLjER gDqXGSm4alaxawlDsz+xovGhR2hshJy70UDrLCFB0BW2mFIxRTDA4ErRXntVaNX/uX9C uIlMuey4OisBBUGk8IpRHljD7EqPT7NMcuaCAcaq85aAEFm78oUAhBgCyHdehPUtdtM1 CL9u/zm+XJgJZaO6B6vGWT2iCJa3UgiBUWD3XvuKdyB2YW25Ri5043whEtX1BtOHVZWw VMPwiRyaXrH2NrYlHVnhB+Iv6QYaesgas0dZ9zoj9eXMEUTdIVr8XCwLe5Dszq0+TpQZ C2cQ== X-Gm-Message-State: AElRT7EZ0PcCzRqqvJ6qEe5klfNCOipHEy+lP8fz0+50YDg//1h4PZ9f +j5MSlopizTjfgXX+g4PFdf/LbE1 X-Google-Smtp-Source: AIpwx4+Gfho+Im/PRGwOCB69qSAWdQzx81CdBGB4w7TviifRds+G+MErhZzED21rdlWLis4LIz5j/Q== X-Received: by 10.80.155.6 with SMTP id o6mr13277479edi.280.1522685312305; Mon, 02 Apr 2018 09:08:32 -0700 (PDT) Received: from mail-wr0-f175.google.com (mail-wr0-f175.google.com. [209.85.128.175]) by smtp.gmail.com with ESMTPSA id v16sm568403edc.5.2018.04.02.09.08.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 Apr 2018 09:08:31 -0700 (PDT) Received: by mail-wr0-f175.google.com with SMTP id y55so14463441wry.3; Mon, 02 Apr 2018 09:08:31 -0700 (PDT) X-Received: by 2002:a19:c4c8:: with SMTP id u191-v6mr6329871lff.109.1522685311446; Mon, 02 Apr 2018 09:08:31 -0700 (PDT) MIME-Version: 1.0 Received: by 10.46.129.90 with HTTP; Mon, 2 Apr 2018 09:08:10 -0700 (PDT) In-Reply-To: <201804021539.w32FdaID083096@pdx.rh.CN85.dnsmgr.net> References: <201804021528.w32FSmd7023856@repo.freebsd.org> <201804021539.w32FdaID083096@pdx.rh.CN85.dnsmgr.net> From: Kyle Evans Date: Mon, 2 Apr 2018 11:08:10 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r331880 - stable/11/etc To: "Rodney W. Grimes" Cc: Kyle Evans , src-committers , svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-stable-11@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for only the 11-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Apr 2018 16:13:49 -0000 On Mon, Apr 2, 2018 at 10:39 AM, Rodney W. Grimes wrote: >> Author: kevans >> Date: Mon Apr 2 15:28:48 2018 >> New Revision: 331880 >> URL: https://svnweb.freebsd.org/changeset/base/331880 >> >> Log: >> MFC r328331: Support configuring arbitrary limits(1) for any rc.conf daemon >> >> Usage is ${name}_limits, and the argument is any flags accepted by >> limits(1), such as `-n 100' (e.g. only allow 100 open files). >> >> Modified: >> stable/11/etc/rc.subr >> Directory Properties: >> stable/11/ (props changed) >> >> Modified: stable/11/etc/rc.subr >> ============================================================================== >> --- stable/11/etc/rc.subr Mon Apr 2 15:07:41 2018 (r331879) >> +++ stable/11/etc/rc.subr Mon Apr 2 15:28:48 2018 (r331880) >> @@ -773,6 +773,8 @@ check_startmsgs() >> # >> # ${name}_login_class n Login class to use, else "daemon". >> # >> +# ${name}_limits n limits(1) to apply to ${command}. >> +# > > Caution, limits(1) is in /usr/bin, this code can fail if used before > /usr is mounted. (Ie, our rc.initdiskless) is probably broken by > this change if a call is made to limits. > I believe this is a non-issue in this case-- this didn't add any limits(1) invocations, it just allowed flags to be passed to the limits(1) invocation that was already being made.