From owner-freebsd-commit Mon Nov 13 23:29:01 1995 Return-Path: owner-commit Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id XAA04601 for freebsd-commit-outgoing; Mon, 13 Nov 1995 23:29:01 -0800 Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id XAA04528 for cvs-all-outgoing; Mon, 13 Nov 1995 23:28:02 -0800 Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id XAA04436 for cvs-sys-outgoing; Mon, 13 Nov 1995 23:27:00 -0800 Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id XAA04338 ; Mon, 13 Nov 1995 23:24:37 -0800 Received: (from bde@localhost) by godzilla.zeta.org.au (8.6.9/8.6.9) id SAA00861; Tue, 14 Nov 1995 18:22:25 +1100 Date: Tue, 14 Nov 1995 18:22:25 +1100 From: Bruce Evans Message-Id: <199511140722.SAA00861@godzilla.zeta.org.au> To: bde@freefall.freebsd.org, davidg@Root.COM Subject: Re: cvs commit: src/sys/nfs nfs_syscalls.c Cc: CVS-commiters@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Sender: owner-commit@FreeBSD.org Precedence: bulk >>bde 95/11/13 21:16:38 >> >> Modified: sys/nfs nfs_syscalls.c >> Log: >> Included to get central declarations for syscall args >> structs and prototypes for syscalls. >> >> Ifdefed duplicated decentralized declarations of args structs. It's >> convenient to have this visible but they are hard to maintain. Some >> are already different from the central declarations. 4.4lite2 puts >> them in comments in the function headers but I wanted to avoid the >> large changes for that. > Now that the definitions are in sysproto.h, I'd like to see them removed >from the .c files. I'm not sure if they should be removed as far as that. Do you think we should remove the pseudo-declarations from all vnode op functions too? Such declarations are useful iff they are correct. For examples of possibly harmful incorrect ones, see almost any readdir(): ext2fs_readdir(): eofflag and cookies are missing eofflag and cookies aren't referenced so nfs can't work ufs_readdir(): eofflag is missing but is referenced (nfs works :-) msdosfs_readdir(): members are out of order Bruce