Date: Sat, 26 Feb 2005 22:38:33 +0100 From: Jose M Rodriguez <josemi@freebsd.jazztel.es> To: Joe Marcus Clarke <marcus@freebsd.org> Cc: FreeBSD GNOME Users <gnome@freebsd.org> Subject: Re: ports/75816: [PATCH] www/firefox: new mozilla.sh and package script Message-ID: <200502262238.34351.josemi@freebsd.jazztel.es> In-Reply-To: <1109410446.61886.27.camel@shumai.marcuscom.com> References: <200502250756.j1P7uEn0023933@freefall.freebsd.org> <200502261027.00849.josemi@freebsd.jazztel.es> <1109410446.61886.27.camel@shumai.marcuscom.com>
next in thread | previous in thread | raw e-mail | index | archive | help
El S=E1bado, 26 de Febrero de 2005 10:34, Joe Marcus Clarke escribi=F3:
> On Sat, 2005-02-26 at 10:27 +0100, Jose M Rodriguez wrote:
> > El S=E1bado, 26 de Febrero de 2005 09:32, Joe Marcus Clarke escribi=F3:
> > > On Fri, 2005-02-25 at 09:22 +0100, Jose M Rodriguez wrote:
> > > > El Viernes, 25 de Febrero de 2005 08:56, Joe Marcus Clarke=20
escribi=F3:
> > > > > Synopsis: [PATCH] www/firefox: new mozilla.sh and package
> > > > > script <snip/>
> > > >
> > > > Please, consider the cleanhome moz_pis for firefox. This makes
> > > > firefox upgrades don't be hurt by local profile.
> > >
> > > This could be useful. However, I have some concerns, and the
> > > comments in the script didn't help. This removes the
> > > pluginreg.dat every time Firefox is started. Will that have any
> > > negative effects? What about performance? Couldn't this be
> > > wrapped about the -ot comparison as well? Also, you have a typo.
> > > The file is XUL.mfasl, not XUL.mfast.
> >
> > Firts, I think we have time until 1.1/1.5 landing, so this can be
> > worked better.
> >
> > - I think having moz_pis processing in the Makefile is a good
> > thing, with or without this or that script. The mozilla.sh script
> > seems to be a common denominator and moz_pis the way to get special
> > things.
> >
> > - The actual script in latest post is:
> > #!/bin/sh
> > #
> >
> > # S50cleanhome
> > # a script to polite ${HOME}/${MOZ_PIS_USER_DIR}
> >
> > # We run in our own subshell
> >
> > # First, verify protocol
> > [ "$1" !=3D "start" ] && exit 1
> > [ -z "${MOZ_PIS_API}" -o ${MOZ_PIS_API} -ne 2 ] && exit 1
> > [ -z "${MOZ_PIS_MOZBINDIR}" -o ! -d "${MOZ_PIS_MOZBINDIR}" ] &&
> > exit 1 [ -z "${HOME}" -o ! -d "${HOME}" ] && exit 1
> > [ -z "${MOZ_PIS_USER_DIR}" -o ! -d "${HOME}/${MOZ_PIS_USER_DIR}" ]
> > && exit 1
> >
> > # Try to polite ${HOME}/${MOZ_PIS_USER_DIR}
> >
> > # This must be really needed?
> > # rm -f "${$HOME}/${MOZ_PIS_USER_DIR}/pluginreg.dat"
> >
> > # Try to polite profile dirs
> > if [ -f "${HOME}/${MOZ_PIS_USER_DIR}/profiles.ini" ]; then
> > sed -e '/Path=3D/! d' -e "s,Path=3D,${HOME}/${MOZ_PIS_USER_DIR}/,"
> > \ "${HOME}/${MOZ_PIS_USER_DIR}/profiles.ini" \
> >
> > | while read dir
> >
> > do
> > [ ! -d "${dir}" ] && continue
> > # at last, debian do this, we do for new builds
> > # rm -f "${dir}/XUL.mfast"
> > # make reclaculate compreg.dat, xpti.dat for new builds
> > [ "${dir}/compreg.dat" -ot
> > "${MOZ_PIS_MOZBINDIR}/components.ini" ] &&
> > rm -f "${dir}/compatibility.ini" "${dir}/XUL.mfast"
> > done
> > fi
> >
> > I try to import debian work, but taking mozilla guidelines.
> >
> > I don't remove pluginreg.dat. But this is done in debian and maybe
> > needed.
>
> I saw this after a more careful reading. In any event, I committed
> the script as it was (with the mfasl bug fix).
>
> > As I comment in the pkg scripts, I'll prefer have just one .keepme
> > file in ${PLUGINDIR} and make all ports, even plugins 'touch this'.
>
> I'll have to see how you do this. In general, touching one file
> across multiple ports is not a good idea.
>
I think that I can do a find/for construct for the age test. There used=20
to be only a few plugins.
Touching (or doing the grep thing) on one .keepme file will reduce this=20
to only a simple age test. But I agree that this may be only easy to=20
say.
> > In any case, If I enable pluginreg.dat removal, must be after a
> > safe age test.
>
> I tested this here, and it seemed to work without removing it.=20
> However, if you find removing it does more good than harm, we can
> consider adding it at a later time.
>
> Joe
=2D-
josemi
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200502262238.34351.josemi>