From owner-svn-src-head@freebsd.org Wed Sep 4 14:45:59 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D7F54F3DC1; Wed, 4 Sep 2019 14:45:59 +0000 (UTC) (envelope-from agapon@gmail.com) Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com [209.85.208.169]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46NmpZ6QW4z4PVL; Wed, 4 Sep 2019 14:45:58 +0000 (UTC) (envelope-from agapon@gmail.com) Received: by mail-lj1-f169.google.com with SMTP id x18so19933886ljh.1; Wed, 04 Sep 2019 07:45:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=zQpcvPmJQMvAeRbrM/dd909f7u4tXMFU18Vtioxkevs=; b=OpkpUfk/LZGt3wsk4MHPvaJ8QaedzdnoBpoCbwlR31qwh2pYQ+JcAr+DO+1o2Ckidp epR4txjUO6X+WOiSkasXOnQIQOtXRr/71CPLT3GZP5aMnROr7lsZloh3aHtYX51OA5cF I9sAPDJeL+CZalbV6zuHOruX59EuGlWoSJrhINoAd1R/A+MsY92r0911LmnS7RxMK1Ej LDixkzwIsFyslhmHk25PSVlVJzMyN6FLVyeVeVI+Ssr7ATdyo7O7ZvqIYx28vjhuRnw4 a9NRT9+9KGn/3HJmduD1y4Sf1Memko/Dnueqb2m1UFXs4m6RYU4kwjpTdmTIvXDyDrvF xjJg== X-Gm-Message-State: APjAAAV+9Th1GOg2xt4mneC12IjyI0juCdoVXvUq4L9f8OL4ISjjwqUF yqUaUtQST8GLr4n0dHHenxyAAhCD X-Google-Smtp-Source: APXvYqxWWrjX+IOXSOpTPkzUbBcRBRVAYTxmaeLwsSIHdqwPJoId57D9x/evvvTmqla3ol8AjZ8EXw== X-Received: by 2002:a2e:898d:: with SMTP id c13mr23530195lji.164.1567608356859; Wed, 04 Sep 2019 07:45:56 -0700 (PDT) Received: from [192.168.0.88] (east.meadow.volia.net. [93.72.151.96]) by smtp.googlemail.com with ESMTPSA id d10sm2529798ljc.66.2019.09.04.07.45.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Sep 2019 07:45:56 -0700 (PDT) Subject: Re: svn commit: r351812 - head/usr.sbin/mpsutil To: Alan Somers Cc: src-committers , svn-src-all , svn-src-head References: <201909041347.x84Dlcds017291@repo.freebsd.org> From: Andriy Gapon Openpgp: preference=signencrypt Autocrypt: addr=avg@FreeBSD.org; prefer-encrypt=mutual; keydata= mQINBFm4LIgBEADNB/3lT7f15UKeQ52xCFQx/GqHkSxEdVyLFZTmY3KyNPQGBtyvVyBfprJ7 mAeXZWfhat6cKNRAGZcL5EmewdQuUfQfBdYmKjbw3a9GFDsDNuhDA2QwFt8BmkiVMRYyvI7l N0eVzszWCUgdc3qqM6qqcgBaqsVmJluwpvwp4ZBXmch5BgDDDb1MPO8AZ2QZfIQmplkj8Y6Z AiNMknkmgaekIINSJX8IzRzKD5WwMsin70psE8dpL/iBsA2cpJGzWMObVTtCxeDKlBCNqM1i gTXta1ukdUT7JgLEFZk9ceYQQMJJtUwzWu1UHfZn0Fs29HTqawfWPSZVbulbrnu5q55R4PlQ /xURkWQUTyDpqUvb4JK371zhepXiXDwrrpnyyZABm3SFLkk2bHlheeKU6Yql4pcmSVym1AS4 dV8y0oHAfdlSCF6tpOPf2+K9nW1CFA8b/tw4oJBTtfZ1kxXOMdyZU5fiG7xb1qDgpQKgHUX8 7Rd2T1UVLVeuhYlXNw2F+a2ucY+cMoqz3LtpksUiBppJhw099gEXehcN2JbUZ2TueJdt1FdS ztnZmsHUXLxrRBtGwqnFL7GSd6snpGIKuuL305iaOGODbb9c7ne1JqBbkw1wh8ci6vvwGlzx rexzimRaBzJxlkjNfMx8WpCvYebGMydNoeEtkWldtjTNVsUAtQARAQABtB5BbmRyaXkgR2Fw b24gPGF2Z0BGcmVlQlNELm9yZz6JAlQEEwEIAD4WIQS+LEO7ngQnXA4Bjr538m7TUc1yjwUC WbgsiAIbIwUJBaOagAULCQgHAgYVCAkKCwIEFgIDAQIeAQIXgAAKCRB38m7TUc1yj+JAEACV l9AK/nOWAt/9cufV2fRj0hdOqB1aCshtSrwHk/exXsDa4/FkmegxXQGY+3GWX3deIyesbVRL rYdtdK0dqJyT1SBqXK1h3/at9rxr9GQA6KWOxTjUFURsU7ok/6SIlm8uLRPNKO+yq0GDjgaO LzN+xykuBA0FlhQAXJnpZLcVfPJdWv7sSHGedL5ln8P8rxR+XnmsA5TUaaPcbhTB+mG+iKFj GghASDSfGqLWFPBlX/fpXikBDZ1gvOr8nyMY9nXhgfXpq3B6QCRYKPy58ChrZ5weeJZ29b7/ QdEO8NFNWHjSD9meiLdWQaqo9Y7uUxN3wySc/YUZxtS0bhAd8zJdNPsJYG8sXgKjeBQMVGuT eCAJFEYJqbwWvIXMfVWop4+O4xB+z2YE3jAbG/9tB/GSnQdVSj3G8MS80iLS58frnt+RSEw/ psahrfh0dh6SFHttE049xYiC+cM8J27Aaf0i9RflyITq57NuJm+AHJoU9SQUkIF0nc6lfA+o JRiyRlHZHKoRQkIg4aiKaZSWjQYRl5Txl0IZUP1dSWMX4s3XTMurC/pnja45dge/4ESOtJ9R 8XuIWg45Oq6MeIWdjKddGhRj3OohsltKgkEU3eLKYtB6qRTQypHHUawCXz88uYt5e3w4V16H lCpSTZV/EVHnNe45FVBlvK7k7HFfDDkryLkCDQRZuCyIARAAlq0slcsVboY/+IUJdcbEiJRW be9HKVz4SUchq0z9MZPX/0dcnvz/gkyYA+OuM78dNS7Mbby5dTvOqfpLJfCuhaNYOhlE0wY+ 1T6Tf1f4c/uA3U/YiadukQ3+6TJuYGAdRZD5EqYFIkreARTVWg87N9g0fT9BEqLw9lJtEGDY EWUE7L++B8o4uu3LQFEYxcrb4K/WKmgtmFcm77s0IKDrfcX4doV92QTIpLiRxcOmCC/OCYuO jB1oaaqXQzZrCutXRK0L5XN1Y1PYjIrEzHMIXmCDlLYnpFkK+itlXwlE2ZQxkfMruCWdQXye syl2fynAe8hvp7Mms9qU2r2K9EcJiR5N1t1C2/kTKNUhcRv7Yd/vwusK7BqJbhlng5ZgRx0m WxdntU/JLEntz3QBsBsWM9Y9wf2V4tLv6/DuDBta781RsCB/UrU2zNuOEkSixlUiHxw1dccI 6CVlaWkkJBxmHX22GdDFrcjvwMNIbbyfQLuBq6IOh8nvu9vuItup7qemDG3Ms6TVwA7BD3j+ 3fGprtyW8Fd/RR2bW2+LWkMrqHffAr6Y6V3h5kd2G9Q8ZWpEJk+LG6Mk3fhZhmCnHhDu6CwN MeUvxXDVO+fqc3JjFm5OxhmfVeJKrbCEUJyM8ESWLoNHLqjywdZga4Q7P12g8DUQ1mRxYg/L HgZY3zfKOqcAEQEAAYkCPAQYAQgAJhYhBL4sQ7ueBCdcDgGOvnfybtNRzXKPBQJZuCyIAhsM BQkFo5qAAAoJEHfybtNRzXKPBVwQAKfFy9P7N3OsLDMB56A4Kf+ZT+d5cIx0Yiaf4n6w7m3i ImHHHk9FIetI4Xe54a2IXh4Bq5UkAGY0667eIs+Z1Ea6I2i27Sdo7DxGwq09Qnm/Y65ADvXs 3aBvokCcm7FsM1wky395m8xUos1681oV5oxgqeRI8/76qy0hD9WR65UW+HQgZRIcIjSel9vR XDaD2HLGPTTGr7u4v00UeTMs6qvPsa2PJagogrKY8RXdFtXvweQFz78NbXhluwix2Tb9ETPk LIpDrtzV73CaE2aqBG/KrboXT2C67BgFtnk7T7Y7iKq4/XvEdDWscz2wws91BOXuMMd4c/c4 OmGW9m3RBLufFrOag1q5yUS9QbFfyqL6dftJP3Zq/xe+mr7sbWbhPVCQFrH3r26mpmy841ym dwQnNcsbIGiBASBSKksOvIDYKa2Wy8htPmWFTEOPRpFXdGQ27awcjjnB42nngyCK5ukZDHi6 w0qK5DNQQCkiweevCIC6wc3p67jl1EMFY5+z+zdTPb3h7LeVnGqW0qBQl99vVFgzLxchKcl0 R/paSFgwqXCZhAKMuUHncJuynDOP7z5LirUeFI8qsBAJi1rXpQoLJTVcW72swZ42IdPiboqx NbTMiNOiE36GqMcTPfKylCbF45JNX4nF9ElM0E+Y8gi4cizJYBRr2FBJgay0b9Cp Message-ID: <63070714-087b-119f-918a-fb1e75a3ab4d@FreeBSD.org> Date: Wed, 4 Sep 2019 17:45:55 +0300 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 46NmpZ6QW4z4PVL X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of agapon@gmail.com designates 209.85.208.169 as permitted sender) smtp.mailfrom=agapon@gmail.com X-Spamd-Result: default: False [-4.20 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[FreeBSD.org]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; IP_SCORE(-1.23)[ip: (-0.49), ipnet: 209.85.128.0/17(-3.33), asn: 15169(-2.28), country: US(-0.05)]; TO_DN_ALL(0.00)[]; NEURAL_HAM_SHORT(-0.97)[-0.973,0]; RCVD_IN_DNSWL_NONE(0.00)[169.208.85.209.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_MEDIUM(-1.00)[-0.998,0]; FORGED_SENDER(0.30)[avg@FreeBSD.org,agapon@gmail.com]; RECEIVED_SPAMHAUS_PBL(0.00)[96.151.72.93.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.10]; MIME_TRACE(0.00)[0:+]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[avg@FreeBSD.org,agapon@gmail.com] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Sep 2019 14:45:59 -0000 On 04/09/2019 16:50, Alan Somers wrote: > On Wed, Sep 4, 2019 at 7:47 AM Andriy Gapon > wrote: > > Author: avg > Date: Wed Sep  4 13:47:38 2019 > New Revision: 351812 > URL: https://svnweb.freebsd.org/changeset/base/351812 > > Log: >   mpsutil slot set status > >   This code has been written as a proof of concept, but I think that it >   can be useful in general.  It allows to set the status of an enclosure >   slot.  Practically, this means controlling whatever slot status LEDs the >   enclosure provides.  At present, the new command does not have sanity >   checks or any conveniences.  That means that it is possible to issue the >   command for an invalid slot and an enclosure.  But the worst I have seen >   happening is either the command failing or simply being ignored.  Also, >   at the moment, the status has to be specified as a numeric bit mask. >   The bit definitions can be found in sys/dev/mps/mpi/mpi2_init.h, they >   are prefixed with MPI2_SEP_REQ_SLOTSTATUS_.  The only way to address a >   slot is by the enclosure handle and the slot number.  Both are readily >   available from mpsutil show commands. > >   So, future enhancements could include alternative ways to address a slot >   (e.g., by a disk handle or a disk device name) and human friendly names >   for slot statuses. > >   The new command is useful alternative to 'sas2ircu locate' command. >   First, sas2ircu is a proprietary blob.  Second, it supports setting only >   locate / identify status bit. > >   Tested on HP H220 running LSI IT firmware 20.x. > >   Reviewed by:  bapt >   MFC after:    3 weeks >   Differential Revision:        https://reviews.freebsd.org/D20535 > > Added: >   head/usr.sbin/mpsutil/mps_slot.c   (contents, props changed) > Modified: >   head/usr.sbin/mpsutil/Makefile >   head/usr.sbin/mpsutil/mps_cmd.c >   head/usr.sbin/mpsutil/mpsutil.h > > > Is this redundant with sesutil, or does it work on different kinds of enclosures?  This is for controllers that do not expose a SES device for a directly attached (no expanders in between) backplane that does not have a built-in expander of its own. Here is some information for a context. I have a configuration with a SAS2308 based HBA that's flashed with LSI IT firmware version 20.00.07.00. I think that the HBA does not support IR firmware as it is very simple and it seems to lack NVSRAM (whatever it is). The controller is attached to a Supermicro 743TQ backplane that's built into a namesake chassis. The attachment is via a fan-out cable that connects one mini-SAS (SFF-8087) port on the controller to four individual SAS/SATA ports on the backplane plus a sideband connector that's attached to the backplane as well. The backplane supports two modes of operation for the sideband connection, I2C and SGPIO. But it seems that the controller or its firmware supports only SGPIO. Maybe I2C communication was considered to be an overkill for the IT mode. In any case, the controller does not fake a SES device for the enclosure, so it's not available for tools like sesutil, etc. The controller specific tools like mpsutil and sas2ircu do see the enclosure. -- Andriy Gapon