Date: Mon, 16 Jan 2012 22:56:39 +0400 From: Ruslan Mahmatkhanov <cvs-src@yandex.ru> To: Max Brazhnikov <makc@freebsd.org> Cc: cvs-ports@freebsd.org, Veniamin Gvozdikov <g.veniamin@googlemail.com>, Axel Gonzalez <loox@e-shell.net>, cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/audio/clementine-player Makefile ports/audio/clementine-player/files patch-src-devices-cddadevice.h patch-src-devices-cddalister.cpp Message-ID: <4F1472E7.3010309@yandex.ru> In-Reply-To: <201201161838.12941.makc@freebsd.org> References: <201201130338.q0D3cMgJ018062@repoman.freebsd.org> <201201161838.12941.makc@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Max Brazhnikov wrote on 16.01.2012 22:38: > On Fri, 13 Jan 2012 03:38:22 +0000 (UTC), Ruslan Mahmatkhanov wrote: >> rm 2012-01-13 03:38:22 UTC >> >> FreeBSD ports repository >> >> Modified files: >> audio/clementine-player Makefile >> Added files: >> audio/clementine-player/files patch-src-devices-cddadevice.h >> patch-src-devices-cddalister.cpp >> Log: >> - let it build with stock gcc >> - optionify ipod and mtp support (default on) > > This type of `port optionification' leads to a nasty problem of hidden > dependencies when options are unchecked, but corresponding libraries are > presented. Please consider to commit the patch, which makes optional support > really optional. > > Max You are right, thank you. Veniamin, do you have any objections if this patch will be committed? -- Regards, Ruslan Tinderboxing kills... the drives.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4F1472E7.3010309>