From owner-freebsd-ports@FreeBSD.ORG Fri May 25 16:22:01 2012 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E146B106566B; Fri, 25 May 2012 16:22:01 +0000 (UTC) (envelope-from rsimmons0@gmail.com) Received: from mail-vb0-f54.google.com (mail-vb0-f54.google.com [209.85.212.54]) by mx1.freebsd.org (Postfix) with ESMTP id 5963A8FC08; Fri, 25 May 2012 16:22:01 +0000 (UTC) Received: by vbmv11 with SMTP id v11so1000446vbm.13 for ; Fri, 25 May 2012 09:21:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=B75J4oyemwDyVJ1jFy4U1y/oFDPN0QNaXOms9p4+YMg=; b=YYKouputhxvT9CteM6VIkC8llc/MJGiKuYo9hx6MLHjCV0rpOTmnzJI6ST5Kdk1d/3 am8zF416F9lq1d0HW28wmHIdhhZk+rfIEU07V0EiF0TrYFjkky7OW7dkcCicuFVYqgrp vV0UAjbO4Neo22qc6eIbTsJHm95QeFrGb+BzYINxB7pTIDvqFcLawHAKpWeVFqImMDjL FIjqCPA26CPyAGSVcSz5poMJOkEKexEqODZ9gqInqOOQ9u6UIqdYYKdGd1QCqDitIp8J FOfBWSDIznk1EnAIDaV7f+8pignbHBdH1U/oVlpi6WJWQg//dT1HyTcCSi9Il4Q5344D FMmA== MIME-Version: 1.0 Received: by 10.52.95.147 with SMTP id dk19mr3609456vdb.106.1337962914885; Fri, 25 May 2012 09:21:54 -0700 (PDT) Received: by 10.52.113.97 with HTTP; Fri, 25 May 2012 09:21:54 -0700 (PDT) In-Reply-To: <20120525003844.GA24924@atarininja.org> References: <4FAD492C.3060807@gmx.de> <9880B4F2567E41A582B6B9DA178AECFD@black> <20120522125710.GB18115@atarininja.org> <20120522211434.GA5483@atarininja.org> <20120525003844.GA24924@atarininja.org> Date: Fri, 25 May 2012 12:21:54 -0400 Message-ID: From: Robert Simmons To: Wesley Shields Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: eadler@freebsd.org, freebsd-ports@freebsd.org Subject: Re: Heimdal 1.5.2 problem X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 May 2012 16:22:02 -0000 On Thu, May 24, 2012 at 8:38 PM, Wesley Shields wrote: > On Tue, May 22, 2012 at 06:29:20PM -0400, Robert Simmons wrote: >> On Tue, May 22, 2012 at 5:14 PM, Wesley Shields wrote: >> > On Tue, May 22, 2012 at 03:08:31PM -0400, Robert Simmons wrote: >> >> On Tue, May 22, 2012 at 8:57 AM, Wesley Shields wro= te: >> >> > As the person who committed this update I will take responsibility = for >> >> > seeing this through. Would you mind opening a PR with this patch an= d CC >> >> > both myself and the maintainer so it can be properly tracked. I wil= l >> >> > work with both of you to make sure it is addressed. >> >> >> >> I got some good feedback about the patch. ?I was missing a "\". ?Also= , >> >> it was noted that I shouldn't make changes to the default settings in >> >> this patch since it is meant to correct a problem. ?I removed the >> >> change to default. >> > >> > I'm not opposed to removing the change to the default, but it does cau= se >> > another problem. See below. >> > >> >> Perhaps the different default is not the best solution. ?Maybe there >> >> should be a message that at least one backend is needed for the port >> >> to function, but none have been selected by default? >> > >> > If a backend is required the port should refuse to build if no backend >> > is selected. This is pretty easy to do, just check for at least one of >> > the backends. I have no idea if multiple backends can be supported so >> > you may or may not want to also check for that. >> >> I may have been too hasty. =A0I've thought of a situation where one >> would want to build the port with no backend at all. =A0If one wanted to >> use the tools in the port to administrate a remote install of Heimdal, >> they may want to build it without a backend. >> >> My initial thoughts were only for installing the port as a Heimdal >> server, and with the --with-berkeley-db=3Dno problem fixed it does not >> wrongly find the version of BDB in the base OS. =A0With this fix, the >> port can function with no backends selected. =A0It just won't be able to >> function in a server capacity. >> >> I am also not an expert in Heimdal, I just installed it from source >> via its own instructions and compared that with what the FreeBSD port >> was doing. =A0I'd wait for the maintainer to make changes to the default >> behavior for the above reason. > > This all sounds perfectly reasonable to me. :) > > If I'm understanding you correctly the patch[1] in ports/168214 is the > correct one to commit. The only change I would make is not bumping > PORTREVISION since the option is off by default. Sounds like the only > thing left to do is wait for maintainer comment on the PR and commit > accordingly. Sounds good. One question: what do you mean by PORTREVISION being off by default? > I appreciate your thoroughness in this and apologize for the problem. Thanks!