From owner-freebsd-current@FreeBSD.ORG  Wed Aug 13 16:48:53 2003
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 18F5B37B401
	for <freebsd-current@freebsd.org>;
	Wed, 13 Aug 2003 16:48:53 -0700 (PDT)
Received: from tomts25-srv.bellnexxia.net (tomts25.bellnexxia.net
	[209.226.175.188])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 9B6DC43F75
	for <freebsd-current@freebsd.org>;
	Wed, 13 Aug 2003 16:48:51 -0700 (PDT)	(envelope-from matt@compar.com)
Received: from hermes ([65.95.177.176]) by tomts25-srv.bellnexxia.net
          (InterMail vM.5.01.05.32 201-253-122-126-132-20030307) with SMTP
          id <20030813234850.FXDB20149.tomts25-srv.bellnexxia.net@hermes>;
          Wed, 13 Aug 2003 19:48:50 -0400
Message-ID: <003901c361f5$317db6b0$1200a8c0@gsicomp.on.ca>
From: "Matthew Emmerton" <matt@compar.com>
To: "Craig Rodrigues" <rodrigc@crodrigues.org>,
	<freebsd-current@freebsd.org>
References: <20030913233905.GA3834@crodrigues.org>
Date: Wed, 13 Aug 2003 19:47:01 -0400
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 6.00.2800.1158
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1165
Subject: Re: M_NOTIFICATION in <sys/mbuf.h>?
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Aug 2003 23:48:53 -0000

> Hi,
>
> While trying to port the SCTP-KAME code to CURRENT,
> I noticed that M_NOTIFICATION is missing from <sys/mbuf.h>
> in CURRENT, but it is present in the KAME version of this
> file.
>
> Any reason not to apply this patch?
>
> --- sys/sys/mbuf.h.orig Sat Sep 13 19:34:07 2003
> +++ sys/sys/mbuf.h Sat Sep 13 19:34:14 2003
> @@ -164,6 +164,8 @@
>  #define M_FIRSTFRAG 0x1000 /* packet is first fragment */
>  #define M_LASTFRAG 0x2000 /* packet is last fragment */
>
> +#define M_NOTIFICATION 0x8000 /* notification event */
> +
>  /*
>   * External buffer types: identify ext_buf type.
>   */
>
> KAME guys have it here:
> http://orange.kame.net/dev/cvsweb.cgi/kame/freebsd5/sys/sys/mbuf.h?rev=1.5

The KAME snapshot of our source tree is 3 months out of date.  The most
recent version of mbuf.h is here:
http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/sys/mbuf.h?rev=1.122&content-type=text/plain

We already have 0x8000 assigned, and the only free flags value is 0x4000 -- 
but it conflicts with other private usages in the kernel (as per the CVS
comments.)

Does SCTP-KAME really need a special flag value?

--
Matt Emmerton