From owner-svn-src-head@freebsd.org Wed May 24 14:53:25 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 76F8FD7A057 for ; Wed, 24 May 2017 14:53:25 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from nm20-vm4.bullet.mail.ne1.yahoo.com (nm20-vm4.bullet.mail.ne1.yahoo.com [98.138.91.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 46F6B1281 for ; Wed, 24 May 2017 14:53:25 +0000 (UTC) (envelope-from pfg@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1495637598; bh=WQlOQbTL5h2Oo8BRBokTJenmSFxhGyO6yNYH2lodR8w=; h=Subject:To:References:From:Date:In-Reply-To:From:Subject; b=d88jeUAkYvjMi0XZUu0yCNYXOu9m6g0i4w8b+ctTll8rjKkdtcqs5sGoh4o5v0pNrz6qHNoz3wzUnTHP7ESlQZCkSH6aqFEtFaulReHDHcBBk36TYu80kg52esHXheV0XtTb8rIDg6MOiXBStLPTdpSQOP/6fwDAUyp4qlKkSz3RH99rGbn/z5sxkOcp20jkJjU9eCa/aTsJ4OsvRH/M9AaGi1OiTxoGst+RnlscR2/YR4lbKUpaoBA9OWBLU+iJrg6f5blCAFDsRscELvUdjp6PmHAFw7QNkPgNwviowyVHZrMbwloN2UC7FxyVtsp9GrdVL2sgGLQdUWXaaLNkEg== Received: from [98.138.101.132] by nm20.bullet.mail.ne1.yahoo.com with NNFMP; 24 May 2017 14:53:18 -0000 Received: from [98.138.104.112] by tm20.bullet.mail.ne1.yahoo.com with NNFMP; 24 May 2017 14:53:18 -0000 Received: from [127.0.0.1] by smtp221.mail.ne1.yahoo.com with NNFMP; 24 May 2017 14:53:18 -0000 X-Yahoo-Newman-Id: 508169.93409.bm@smtp221.mail.ne1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: CfyyFkAVM1mh2qSmmQkT0Xb610dbv6dqT.yuQsGSeyo63kG g3UEN0g9ommSGiAciM59uDQ3MYy_BR4i8ptCA6lLSgNHQuQgg.zvThYRo4Xw 8FJDqPvRSqu1NgBr5xbCG1wwhqw_M4NoiJ2i0xSpyvH5DhAdwUpjt_2da7Gb fh5yDbJeUnIAAgH17JqDh_MB4IACdbX0Pm0.RobkA4Ux6lDS9GuFuQMOhnWE Islh.d1if57KmHfZiaDDV6KqsxC_Av2HmLu0IwJ_YTw8GhIREfhIK0eShNZH uHQJExSSPdAP8WcuRmsnzkESoSKUUignKyw6qwWuIGwKQLKUfvL4Zyf3mW6L 4_TJQNKgKea_PxCBYNj8yvh1HLezGaV5Ll1R2eRmwc_tWlvZOo4bSWbnl0Bg qyB.BD28efpLp7c.9RxyUuBxdXmFcf6m4i4JAye3yMv00b6g_2ElXt86iuo6 Cr7qNs0oZB5BaOq7dxXP_90t81.GG8kSLXzMHRtmZiexF0nz2JLapZ4NhQ37 IyoOtlzsb5WboYRYzlPck.NsBI2n.EqZ8hgAY._uz30qQ X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf Subject: Re: svn commit: r318736 - in head: cddl/lib/libzfs contrib/compiler-rt/lib/sanitizer_common contrib/openbsm/libbsm include lib/libarchive lib/libc/gen lib/libc/include lib/libc/sys lib/libkvm lib/libmi... To: Konstantin Belousov , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201705230929.v4N9T5g1028124@repo.freebsd.org> From: Pedro Giffuni Organization: FreeBSD Message-ID: Date: Wed, 24 May 2017 09:53:17 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <201705230929.v4N9T5g1028124@repo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 May 2017 14:53:25 -0000 First of all, HUGE thanks to everyone involved in this project! On 05/23/17 04:29, Konstantin Belousov wrote: > Author: kib > Date: Tue May 23 09:29:05 2017 > New Revision: 318736 > URL: https://svnweb.freebsd.org/changeset/base/318736 > > Log: > Commit the 64-bit inode project. > > Extend the ino_t, dev_t, nlink_t types to 64-bit ints. Modify > struct dirent layout to add d_off, increase the size of d_fileno > to 64-bits, increase the size of d_namlen to 16-bits, and change > the required alignment. Increase struct statfs f_mntfromname[] and > f_mntonname[] array length MNAMELEN to 1024. > > ABI breakage is mitigated by providing compatibility using versioned > symbols, ingenious use of the existing padding in structures, and > by employing other tricks. Unfortunately, not everything can be > fixed, especially outside the base system. For instance, third-party > APIs which pass struct stat around are broken in backward and > forward incompatible ways. > > Kinfo sysctl MIBs ABI is changed in backward-compatible way, but > there is no general mechanism to handle other sysctl MIBS which > return structures where the layout has changed. It was considered > that the breakage is either in the management interfaces, where we > usually allow ABI slip, or is not important. > > Struct xvnode changed layout, no compat shims are provided. > > For struct xtty, dev_t tty device member was reduced to uint32_t. > It was decided that keeping ABI compat in this case is more useful > than reporting 64-bit dev_t, for the sake of pstat. > > Update note: strictly follow the instructions in UPDATING. Build > and install the new kernel with COMPAT_FREEBSD11 option enabled, > then reboot, and only then install new world. > > Credits: The 64-bit inode project, also known as ino64, started life > many years ago as a project by Gleb Kurtsou (gleb). Kirk McKusick > (mckusick) then picked up and updated the patch, and acted as a > flag-waver. Feedback, suggestions, and discussions were carried > by Ed Maste (emaste), John Baldwin (jhb), Jilles Tjoelker (jilles), > and Rick Macklem (rmacklem). Kris Moore (kris) performed an initial > ports investigation followed by an exp-run by Antoine Brodin (antoine). > Essential and all-embracing testing was done by Peter Holm (pho). > The heavy lifting of coordinating all these efforts and bringing the > project to completion were done by Konstantin Belousov (kib). > > Sponsored by: The FreeBSD Foundation (emaste, kib) > Differential revision: https://reviews.freebsd.org/D10439 > There is now a bunch of coverity issues (OVERFLOW_BEFORE_WIDEN mostly) tied to ino64_t. At least the following CIDs are related: 977071, 977072, 977073, 977094, 977095, 977096, 1375572, 1375573, 1375574, 1375575 1375576, 1375577, 1375578, 1375579, 1375580, 1375581, 1375582, 1375584. It may take some time to shake up the issues but the change was very necessary. Thanks again! Pedro.