From owner-svn-ports-all@FreeBSD.ORG Mon Mar 23 14:33:05 2015 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 573D8ECE; Mon, 23 Mar 2015 14:33:05 +0000 (UTC) Received: from theravensnest.org (theraven.freebsd.your.org [216.14.102.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cloud.theravensnest.org", Issuer "StartCom Class 1 Primary Intermediate Server CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 1C62B64F; Mon, 23 Mar 2015 14:33:04 +0000 (UTC) Received: from c124.sec.cl.cam.ac.uk (c124.sec.cl.cam.ac.uk [128.232.18.124]) (authenticated bits=0) by theravensnest.org (8.15.1/8.14.9) with ESMTPSA id t2NEX1wC026127 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 23 Mar 2015 14:33:02 GMT (envelope-from theraven@FreeBSD.org) Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Subject: Re: svn commit: r381955 - head/graphics/gdal From: David Chisnall In-Reply-To: <5510220D.3030505@FreeBSD.org> Date: Mon, 23 Mar 2015 14:33:01 +0000 Content-Transfer-Encoding: quoted-printable Message-Id: References: <201503222011.t2MKBHq7091087@svn.freebsd.org> <20150323015759.GA34402@FreeBSD.org> <550F8505.8010600@FreeBSD.org> <20150323135711.GB27378@ivaldir.etoilebsd.net> <5510220D.3030505@FreeBSD.org> To: Bryan Drewery X-Mailer: Apple Mail (2.2070.6) Cc: svn-ports-head@freebsd.org, Baptiste Daroussin , svn-ports-all@freebsd.org, Alexey Dokuchaev , ports-committers@freebsd.org, Sunpoet Po-Chuan Hsieh X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Mar 2015 14:33:05 -0000 On 23 Mar 2015, at 14:24, Bryan Drewery wrote: >=20 > Reading the responses from David and Tijl I'm still at a loss at how > this is useful. =46rom my understanding, and what David said, -pthread = is > more portable. Reading documentation available from simple searching > leads me, as a naive developer, to use -pthread. Especially when = looking > for Linux documentation. Using either is the same as the other on > FreeBSD as well. So why the major change? I'm not sure there's a global change going on - if so then I wouldn't = recommend it. On FreeBSD, -lpthread and -pthread are equivalent, so = using sed to replace -lpthread with -pthread is redundant work and makes = the port's Makefile more complicated. The change should have made no = difference to the generated package, but made the port simpler. To my = mind, this is a good thing. If upstream uses -pthread or -lpthread, we = should not change one to the other, we should just run with whatever = they use. David